Removal of modemconf plugin

Removal of modemconf plugin

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

Hello,

so the modemconf plugin seemed to be a good idea at the time I wrote it,
but lately is causes more issues and confusion than it solves. So we
will be removing this plugin shortly.

For this to happen the following dependencies need to be solved first:

	1) Move phonesim plugin over to use /etc/ofono/phonesim.conf

	2) Create configure option to build without phonesim support

	3) Create udev rule for Calypso device detection

	4) Modify Calypso plugin to work with udev rule

Using special udev rules for special devices (in conjunction with the
oFono auto-detection rule) make the process of setting up oFono for the
system integrator a lot simpler. No manual configuration file patching
anymore. Just installation of an additional udev rule.

The open here is the ISI modem detection, but this should be clearly
done via a Phonet plugin. And also the N900 specific case inside
modemconf is just wrong. This needs to be fixed and just auto-detected
via Phonet or maybe just via RTNL directly.

Regards

Marcel

Re: Removal of modemconf plugin

[Kalle Valo]

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

Hi Marcel,

Marcel Holtmann <marcel@holtmann.org> writes:

> Using special udev rules for special devices (in conjunction with the
> oFono auto-detection rule) make the process of setting up oFono for the
> system integrator a lot simpler. No manual configuration file patching
> anymore. Just installation of an additional udev rule.
>
> The open here is the ISI modem detection, but this should be clearly
> done via a Phonet plugin. And also the N900 specific case inside
> modemconf is just wrong. This needs to be fixed and just auto-detected
> via Phonet or maybe just via RTNL directly.

What about old style serial port modems? How can we configure them if
you remove modemconf?

-- 
Kalle Valo

Re: Removal of modemconf plugin

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Hi Kalle,

> > Using special udev rules for special devices (in conjunction with the
> > oFono auto-detection rule) make the process of setting up oFono for the
> > system integrator a lot simpler. No manual configuration file patching
> > anymore. Just installation of an additional udev rule.
> >
> > The open here is the ISI modem detection, but this should be clearly
> > done via a Phonet plugin. And also the N900 specific case inside
> > modemconf is just wrong. This needs to be fixed and just auto-detected
> > via Phonet or maybe just via RTNL directly.
> 
> What about old style serial port modems? How can we configure them if
> you remove modemconf?

with a proper udev rule. All old style modems show up in udev as well.

Regards

Marcel

RE: Removal of modemconf plugin

[Zhang, Caiwen]

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

Hi Marcel,

What about dual mode modems that with two different serial ports? 
e.g. a modem support both GSM and CDMA, there is a serial port
For GSM, and there is a serial another for CDMA.


Why not keep both udev and modemconf plug-in. It remains for the user
To decide which way to use. I think maybe we can change the compile
Scrips, let user to select which plug-in to use.

Best regards,
Caiwen

> -----Original Message-----
> From: Marcel Holtmann [mailto:marcel(a)holtmann.org]
> Sent: Friday, August 13, 2010 8:56 PM
> To: ofono(a)ofono.org
> Subject: Re: Removal of modemconf plugin
> 
> Hi Kalle,
> 
> > > Using special udev rules for special devices (in conjunction with
> the
> > > oFono auto-detection rule) make the process of setting up oFono for
> the
> > > system integrator a lot simpler. No manual configuration file
> patching
> > > anymore. Just installation of an additional udev rule.
> > >
> > > The open here is the ISI modem detection, but this should be
> clearly
> > > done via a Phonet plugin. And also the N900 specific case inside
> > > modemconf is just wrong. This needs to be fixed and just auto-
> detected
> > > via Phonet or maybe just via RTNL directly.
> >
> > What about old style serial port modems? How can we configure them if
> > you remove modemconf?
> 
> with a proper udev rule. All old style modems show up in udev as well.
> 
> Regards
> 
> Marcel
> 
> 

RE: Removal of modemconf plugin

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

Hi Caiwen,

a gentle reminder that this mailing list doesn't allow top posting,
please follow the netiquette for open source mailing lists.

> What about dual mode modems that with two different serial ports? 
> e.g. a modem support both GSM and CDMA, there is a serial port
> For GSM, and there is a serial another for CDMA.
> 
> 
> Why not keep both udev and modemconf plug-in. It remains for the user
> To decide which way to use. I think maybe we can change the compile
> Scrips, let user to select which plug-in to use.

I don't even see a problem with this at all. Every serial port is
present in udev, so you can write proper udev rules for it. A modem with
a serial port for GSM and another one CDMA will be just presented as two
modems inside oFono. So no problem at all.

So modemconf plugin will be removed since it is not needed at all. The
only component that needs it is the phonesim plugin. And that will get
its own configuration file.

Regards

Marcel

RE: Removal of modemconf plugin

[Gu, Yang]

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

Hi,


>-----Original Message-----
>From: ofono-bounces(a)ofono.org [mailto:ofono-bounces(a)ofono.org] On Behalf Of
>Marcel Holtmann
>Sent: Tuesday, August 17, 2010 5:54 PM
>To: ofono(a)ofono.org
>Subject: RE: Removal of modemconf plugin
>
>Hi Caiwen,
>
>a gentle reminder that this mailing list doesn't allow top posting,
>please follow the netiquette for open source mailing lists.
>
>> What about dual mode modems that with two different serial ports?
>> e.g. a modem support both GSM and CDMA, there is a serial port
>> For GSM, and there is a serial another for CDMA.
>>
>>
>> Why not keep both udev and modemconf plug-in. It remains for the user
>> To decide which way to use. I think maybe we can change the compile
>> Scrips, let user to select which plug-in to use.
>
>I don't even see a problem with this at all. Every serial port is
>present in udev, so you can write proper udev rules for it. A modem with
>a serial port for GSM and another one CDMA will be just presented as two
>modems inside oFono. So no problem at all.
>
>So modemconf plugin will be removed since it is not needed at all. The
>only component that needs it is the phonesim plugin. And that will get
>its own configuration file.

Can we just add some code in phonesim to make it look like a pseudo serial device which can be managed by udev? That is, if we start the phonesim, it will simulate some tty ports under /dev and udevd will inform the oFono there is a new device (We need some rule for phonesim). And the device disappears if phonesim meets an end.
Maybe this is possible if we can send message to udevd the same way as kernel via netlink.

>
>Regards
>
>Marcel
>



Regards,
-Yang

RE: Removal of modemconf plugin

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

Hi Yang,

> >> What about dual mode modems that with two different serial ports?
> >> e.g. a modem support both GSM and CDMA, there is a serial port
> >> For GSM, and there is a serial another for CDMA.
> >>
> >>
> >> Why not keep both udev and modemconf plug-in. It remains for the user
> >> To decide which way to use. I think maybe we can change the compile
> >> Scrips, let user to select which plug-in to use.
> >
> >I don't even see a problem with this at all. Every serial port is
> >present in udev, so you can write proper udev rules for it. A modem with
> >a serial port for GSM and another one CDMA will be just presented as two
> >modems inside oFono. So no problem at all.
> >
> >So modemconf plugin will be removed since it is not needed at all. The
> >only component that needs it is the phonesim plugin. And that will get
> >its own configuration file.
> 
> Can we just add some code in phonesim to make it look like a pseudo serial device which can be managed by udev? That is, if we start the phonesim, it will simulate some tty ports under /dev and udevd will inform the oFono there is a new device (We need some rule for phonesim). And the device disappears if phonesim meets an end.
> Maybe this is possible if we can send message to udevd the same way as kernel via netlink.

in theory yes, but phonesim is the one piece that also works via TCP. So
just having a /etc/ofono/phonesim.conf is a lot simpler.

Regards

Marcel

RE: Removal of modemconf plugin

[Wang, Pengzhuo]

[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]

Hi Marcel,

Best Regards
 
pengzhuo wang(bobwang)
Professional Service | WindRiver P.R.China Room3-H,New JinQiao Plaza,
No.585 Xizhang Rd(M),Shanghai,200003,P.R.C Tel:86-21-63585586/87/89/90
ext.208 Fax:86-21-63585591

 

> -----Original Message-----
> From: ofono-bounces(a)ofono.org 
> [mailto:ofono-bounces(a)ofono.org] On Behalf Of Marcel Holtmann
> Sent: Tuesday, August 17, 2010 5:54 PM
> To: ofono(a)ofono.org
> Subject: RE: Removal of modemconf plugin
> 
> Hi Caiwen,
> 
> a gentle reminder that this mailing list doesn't allow top 
> posting, please follow the netiquette for open source mailing lists.
> 
> > What about dual mode modems that with two different serial ports? 
> > e.g. a modem support both GSM and CDMA, there is a serial port For 
> > GSM, and there is a serial another for CDMA.
> > 
> > 
> > Why not keep both udev and modemconf plug-in. It remains 
> for the user 
> > To decide which way to use. I think maybe we can change the compile 
> > Scrips, let user to select which plug-in to use.
> 
> I don't even see a problem with this at all. Every serial 
> port is present in udev, so you can write proper udev rules 
> for it. A modem with a serial port for GSM and another one 
> CDMA will be just presented as two modems inside oFono. So no 
> problem at all.
> 
Udev really can work, but in many embedded devices,udev service is being
forbidden because
of boot-up speed issue. In addtion, on these devices, device nodes are
often explictly defined.
 
> So modemconf plugin will be removed since it is not needed at 
> all. The only component that needs it is the phonesim plugin. 
> And that will get its own configuration file.
> 
> Regards
> 
> Marcel
> 
> 
> _______________________________________________
> ofono mailing list
> ofono(a)ofono.org
> http://lists.ofono.org/listinfo/ofono
> 

RE: Removal of modemconf plugin

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]

Hi Pengzhuo,

> > a gentle reminder that this mailing list doesn't allow top 
> > posting, please follow the netiquette for open source mailing lists.
> > 
> > > What about dual mode modems that with two different serial ports? 
> > > e.g. a modem support both GSM and CDMA, there is a serial port For 
> > > GSM, and there is a serial another for CDMA.
> > > 
> > > 
> > > Why not keep both udev and modemconf plug-in. It remains 
> > for the user 
> > > To decide which way to use. I think maybe we can change the compile 
> > > Scrips, let user to select which plug-in to use.
> > 
> > I don't even see a problem with this at all. Every serial 
> > port is present in udev, so you can write proper udev rules 
> > for it. A modem with a serial port for GSM and another one 
> > CDMA will be just presented as two modems inside oFono. So no 
> > problem at all.
> > 
> Udev really can work, but in many embedded devices,udev service is being
> forbidden because
> of boot-up speed issue. In addtion, on these devices, device nodes are
> often explictly defined.

this is just an urban myth. udev works as nicely on embedded system as
it works on servers. If you think it is not working fine, then lets have
Kay fix it. Also with the integration of devtmpfs all the last issues
with initial device nodes are solved and udev execution time on a really
static environment is almost non existent. If you have a problem with
your boot time, then it is somewhere else. I highly doubt it is really a
problem of udev.

Regards

Marcel

Re: Removal of modemconf plugin

[Pekka Pessi]

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

2010/8/12 Marcel Holtmann <marcel@holtmann.org>:
> The open here is the ISI modem detection, but this should be clearly
> done via a Phonet plugin. And also the N900 specific case inside
> modemconf is just wrong. This needs to be fixed and just auto-detected
> via Phonet or maybe just via RTNL directly.

Once we get proper n900modem driver tested and integrated, the
isimodem stuff can be removed, too.

-- 
Pekka.Pessi mail at nokia.com

Re: Removal of modemconf plugin

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Hi Pekka,

> > The open here is the ISI modem detection, but this should be clearly
> > done via a Phonet plugin. And also the N900 specific case inside
> > modemconf is just wrong. This needs to be fixed and just auto-detected
> > via Phonet or maybe just via RTNL directly.
> 
> Once we get proper n900modem driver tested and integrated, the
> isimodem stuff can be removed, too.

so how close are you with that. I am going to remove modemconf sooner
than later actually.

Regards

Marcel

Re: Removal of modemconf plugin

[Pekka Pessi]

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

2010/8/13 Marcel Holtmann <marcel@holtmann.org>:
>> > The open here is the ISI modem detection, but this should be clearly
>> > done via a Phonet plugin. And also the N900 specific case inside
>> > modemconf is just wrong. This needs to be fixed and just auto-detected
>> > via Phonet or maybe just via RTNL directly.
>>
>> Once we get proper n900modem driver tested and integrated, the
>> isimodem stuff can be removed, too.
>
> so how close are you with that. I am going to remove modemconf sooner
> than later actually.

I'll try to test it against meego kernel, but I have some problems
(like, usb ethernet does not get up so I could see what is happening
there.)

However, I can post the almost completely untested version once I've
split it into digestable pieces.

-- 
Pekka.Pessi mail at nokia.com