From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: alsa-devel@alsa-project.org,
Jassi Brar <jassisinghbrar@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Seungwhan Youn <sw.youn@samsung.com>
Subject: [PATCH 2/7] ASoC: Convert WM8580 hw_params to use snd_soc_update_bits()
Date: Fri, 13 Aug 2010 20:35:02 +0100 [thread overview]
Message-ID: <1281728107-25386-2-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20100813193305.GB3778@sirena.org.uk>
All the cool kids are using snd_soc_update_bits() these days.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8580.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/codecs/wm8580.c
index b1a80e5..4f41419 100644
--- a/sound/soc/codecs/wm8580.c
+++ b/sound/soc/codecs/wm8580.c
@@ -485,9 +485,8 @@ static int wm8580_paif_hw_params(struct snd_pcm_substream *substream,
{
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct snd_soc_codec *codec = rtd->codec;
- u16 paifb = snd_soc_read(codec, WM8580_PAIF3 + dai->driver->id);
+ u16 paifb = 0;
- paifb &= ~WM8580_AIF_LENGTH_MASK;
/* bit size */
switch (params_format(params)) {
case SNDRV_PCM_FORMAT_S16_LE:
@@ -505,7 +504,8 @@ static int wm8580_paif_hw_params(struct snd_pcm_substream *substream,
return -EINVAL;
}
- snd_soc_write(codec, WM8580_PAIF3 + dai->driver->id, paifb);
+ snd_soc_update_bits(codec, WM8580_PAIF3 + dai->driver->id,
+ WM8580_AIF_LENGTH_MASK, paifb);
return 0;
}
--
1.7.1
next prev parent reply other threads:[~2010-08-13 19:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 19:33 [PATCH 0/7] WM8580 updates Mark Brown
2010-08-13 19:35 ` [PATCH 1/7] ASoC: Add a bit of resource unwinding in the S3C IISv4 driver Mark Brown
2010-08-13 19:35 ` Mark Brown [this message]
2010-08-13 19:35 ` [PATCH 3/7] ASoC: Remove unused rate selection bitmasks from WM8580 Mark Brown
2010-08-13 19:35 ` [PATCH 4/7] ASoC: Automatically calculate clock ratio for WM8580 Mark Brown
2010-08-15 9:00 ` Seungwhan Youn
2010-08-15 11:09 ` Mark Brown
2010-08-16 4:36 ` Jassi Brar
2010-08-16 10:20 ` Mark Brown
2010-08-16 12:51 ` Jassi Brar
2010-08-16 15:19 ` Mark Brown
2010-08-16 23:14 ` Jassi Brar
2010-08-17 9:46 ` Mark Brown
2010-08-31 6:46 ` Jassi Brar
2010-08-31 10:42 ` Mark Brown
2010-08-16 4:16 ` Seungwhan Youn
2010-08-16 12:21 ` Mark Brown
2010-08-16 12:47 ` Jassi Brar
2010-08-13 19:35 ` [PATCH 5/7] ASoC: Implement BCLK rate selection " Mark Brown
2010-08-13 19:35 ` [PATCH 6/7] ASoC: Fix inverted WM8580 capture mute control Mark Brown
2010-08-15 4:50 ` Seungwhan Youn
2010-08-15 6:20 ` Seungwhan Youn
2010-08-13 19:35 ` [PATCH 7/7] ASoC: Automatically manage WM8580 DAC OSR Mark Brown
2010-08-14 4:09 ` [PATCH 0/7] WM8580 updates Jassi Brar
2010-08-15 9:21 ` Seungwhan Youn
2010-08-15 11:10 ` Mark Brown
2010-08-16 9:44 ` Seungwhan Youn
2010-08-16 14:49 ` Mark Brown
2010-08-19 11:37 ` Seungwhan Youn
2010-08-14 10:45 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281728107-25386-2-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jassisinghbrar@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=sw.youn@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.