From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Seungwhan Youn <claude.youn@gmail.com>
Cc: Seungwhan Youn <sw.youn@samsung.com>,
alsa-devel@alsa-project.org,
Jassi Brar <jassisinghbrar@gmail.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 4/7] ASoC: Automatically calculate clock ratio for WM8580
Date: Mon, 16 Aug 2010 13:21:22 +0100 [thread overview]
Message-ID: <20100816122122.GC3276@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <AANLkTin2DtMjwgdiTnxuu+W8B2Jgfoo0VWT9EO_Tjikc@mail.gmail.com>
On Mon, Aug 16, 2010 at 01:16:15PM +0900, Seungwhan Youn wrote:
> On Sat, Aug 14, 2010 at 4:35 AM, Mark Brown
So, this is a great example of a general problem with your mails: you're
generally very light on detail. This makes it hard to work out exactly
what you're talking about. This applies to both regular e-mails and
also patches where your descriptions also tend towards the terse.
> > + switch (dai->driver->id) {
> > + case WM8580_DAI_PAIFTX:
>
> should be WM8580_DAI_PAIFRX:
> Because, WM8580_DAI_PAIFTX --> Capture --> ADC.
Gah, right.
> > + return snd_soc_update_bits(codec, WM8580_CLKSEL, sel, sel_mask);
> Seems the value and mask arguments are swapped ?
Yup.
next prev parent reply other threads:[~2010-08-16 12:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 19:33 [PATCH 0/7] WM8580 updates Mark Brown
2010-08-13 19:35 ` [PATCH 1/7] ASoC: Add a bit of resource unwinding in the S3C IISv4 driver Mark Brown
2010-08-13 19:35 ` [PATCH 2/7] ASoC: Convert WM8580 hw_params to use snd_soc_update_bits() Mark Brown
2010-08-13 19:35 ` [PATCH 3/7] ASoC: Remove unused rate selection bitmasks from WM8580 Mark Brown
2010-08-13 19:35 ` [PATCH 4/7] ASoC: Automatically calculate clock ratio for WM8580 Mark Brown
2010-08-15 9:00 ` Seungwhan Youn
2010-08-15 11:09 ` Mark Brown
2010-08-16 4:36 ` Jassi Brar
2010-08-16 10:20 ` Mark Brown
2010-08-16 12:51 ` Jassi Brar
2010-08-16 15:19 ` Mark Brown
2010-08-16 23:14 ` Jassi Brar
2010-08-17 9:46 ` Mark Brown
2010-08-31 6:46 ` Jassi Brar
2010-08-31 10:42 ` Mark Brown
2010-08-16 4:16 ` Seungwhan Youn
2010-08-16 12:21 ` Mark Brown [this message]
2010-08-16 12:47 ` Jassi Brar
2010-08-13 19:35 ` [PATCH 5/7] ASoC: Implement BCLK rate selection " Mark Brown
2010-08-13 19:35 ` [PATCH 6/7] ASoC: Fix inverted WM8580 capture mute control Mark Brown
2010-08-15 4:50 ` Seungwhan Youn
2010-08-15 6:20 ` Seungwhan Youn
2010-08-13 19:35 ` [PATCH 7/7] ASoC: Automatically manage WM8580 DAC OSR Mark Brown
2010-08-14 4:09 ` [PATCH 0/7] WM8580 updates Jassi Brar
2010-08-15 9:21 ` Seungwhan Youn
2010-08-15 11:10 ` Mark Brown
2010-08-16 9:44 ` Seungwhan Youn
2010-08-16 14:49 ` Mark Brown
2010-08-19 11:37 ` Seungwhan Youn
2010-08-14 10:45 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816122122.GC3276@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=claude.youn@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=sw.youn@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.