* [PATCH] tlv320aic3x symmetric rates
@ 2010-08-18 9:09 Randolph Chung
2010-08-18 9:19 ` Mark Brown
2010-08-18 13:00 ` Mark Brown
0 siblings, 2 replies; 6+ messages in thread
From: Randolph Chung @ 2010-08-18 9:09 UTC (permalink / raw)
To: alsa-devel
The tlv320aic3x codec driver only supports symmetric rates for
capture/playback. Set the flag in the DAI accordingly.
Signed-off-by: Randolph Chung <tausq@parisc-linux.org>
diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index 71a6990..63cad43 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -1116,6 +1116,7 @@ struct snd_soc_dai aic3x_dai = {
.rates = AIC3X_RATES,
.formats = AIC3X_FORMATS,},
.ops = &aic3x_dai_ops,
+ .symmetric_rates = 1,
};
EXPORT_SYMBOL_GPL(aic3x_dai);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] tlv320aic3x symmetric rates
2010-08-18 9:09 [PATCH] tlv320aic3x symmetric rates Randolph Chung
@ 2010-08-18 9:19 ` Mark Brown
2010-08-18 12:54 ` Liam Girdwood
2010-08-18 13:00 ` Mark Brown
1 sibling, 1 reply; 6+ messages in thread
From: Mark Brown @ 2010-08-18 9:19 UTC (permalink / raw)
To: Randolph Chung; +Cc: alsa-devel, lrg
On Wed, Aug 18, 2010 at 05:09:45PM +0800, Randolph Chung wrote:
> The tlv320aic3x codec driver only supports symmetric rates for
> capture/playback. Set the flag in the DAI accordingly.
>
> Signed-off-by: Randolph Chung <tausq@parisc-linux.org>
Please remember to always CC maintainers on patches.
> diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
> index 71a6990..63cad43 100644
> --- a/sound/soc/codecs/tlv320aic3x.c
> +++ b/sound/soc/codecs/tlv320aic3x.c
> @@ -1116,6 +1116,7 @@ struct snd_soc_dai aic3x_dai = {
> .rates = AIC3X_RATES,
> .formats = AIC3X_FORMATS,},
> .ops = &aic3x_dai_ops,
> + .symmetric_rates = 1,
> };
> EXPORT_SYMBOL_GPL(aic3x_dai);
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
--
"You grabbed my hand and we fell into it, like a daydream - or a fever."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tlv320aic3x symmetric rates
2010-08-18 9:19 ` Mark Brown
@ 2010-08-18 12:54 ` Liam Girdwood
0 siblings, 0 replies; 6+ messages in thread
From: Liam Girdwood @ 2010-08-18 12:54 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Randolph Chung
On Wed, 2010-08-18 at 10:19 +0100, Mark Brown wrote:
> On Wed, Aug 18, 2010 at 05:09:45PM +0800, Randolph Chung wrote:
> > The tlv320aic3x codec driver only supports symmetric rates for
> > capture/playback. Set the flag in the DAI accordingly.
> >
> > Signed-off-by: Randolph Chung <tausq@parisc-linux.org>
>
> Please remember to always CC maintainers on patches.
>
> > diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
> > index 71a6990..63cad43 100644
> > --- a/sound/soc/codecs/tlv320aic3x.c
> > +++ b/sound/soc/codecs/tlv320aic3x.c
> > @@ -1116,6 +1116,7 @@ struct snd_soc_dai aic3x_dai = {
> > .rates = AIC3X_RATES,
> > .formats = AIC3X_FORMATS,},
> > .ops = &aic3x_dai_ops,
> > + .symmetric_rates = 1,
> > };
> > EXPORT_SYMBOL_GPL(aic3x_dai);
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tlv320aic3x symmetric rates
2010-08-18 9:09 [PATCH] tlv320aic3x symmetric rates Randolph Chung
2010-08-18 9:19 ` Mark Brown
@ 2010-08-18 13:00 ` Mark Brown
2010-08-19 4:23 ` Randolph Chung
1 sibling, 1 reply; 6+ messages in thread
From: Mark Brown @ 2010-08-18 13:00 UTC (permalink / raw)
To: Randolph Chung; +Cc: alsa-devel
On Wed, Aug 18, 2010 at 05:09:45PM +0800, Randolph Chung wrote:
> The tlv320aic3x codec driver only supports symmetric rates for
> capture/playback. Set the flag in the DAI accordingly.
>
> Signed-off-by: Randolph Chung <tausq@parisc-linux.org>
>
> diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
> index 71a6990..63cad43 100644
> --- a/sound/soc/codecs/tlv320aic3x.c
> +++ b/sound/soc/codecs/tlv320aic3x.c
> @@ -1116,6 +1116,7 @@ struct snd_soc_dai aic3x_dai = {
> .rates = AIC3X_RATES,
> .formats = AIC3X_FORMATS,},
> .ops = &aic3x_dai_ops,
> + .symmetric_rates = 1,
> };
> EXPORT_SYMBOL_GPL(aic3x_dai);
> _______________________________________________
This doesn't apply due to corruption, I've not checked the exact cause
but I suspect either whitespace damage or the lack of any separation
between the context and the signature. Could you please resend?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tlv320aic3x symmetric rates
2010-08-18 13:00 ` Mark Brown
@ 2010-08-19 4:23 ` Randolph Chung
2010-08-19 11:08 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Randolph Chung @ 2010-08-19 4:23 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, lrg
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
> This doesn't apply due to corruption, I've not checked the exact cause
> but I suspect either whitespace damage or the lack of any separation
> between the context and the signature. Could you please resend?
>
Sorry about that. Included as an attachment this time.
randolph
[-- Attachment #2: tlv320aic3x.diff --]
[-- Type: application/octet-stream, Size: 554 bytes --]
The tlv320aic3x codec driver only supports symmetric rates for capture/
playback. Set the flag in the DAI accordingly.
Signed-off-by: Randolph Chung <tausq@parisc-linux.org>
diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index 71a6990..63cad43 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -1116,6 +1116,7 @@ struct snd_soc_dai aic3x_dai = {
.rates = AIC3X_RATES,
.formats = AIC3X_FORMATS,},
.ops = &aic3x_dai_ops,
+ .symmetric_rates = 1,
};
EXPORT_SYMBOL_GPL(aic3x_dai);
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] tlv320aic3x symmetric rates
2010-08-19 4:23 ` Randolph Chung
@ 2010-08-19 11:08 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2010-08-19 11:08 UTC (permalink / raw)
To: Randolph Chung; +Cc: alsa-devel, lrg
On Thu, Aug 19, 2010 at 12:23:49PM +0800, Randolph Chung wrote:
> > This doesn't apply due to corruption, I've not checked the exact cause
> > but I suspect either whitespace damage or the lack of any separation
> > between the context and the signature. Could you please resend?
> Sorry about that. Included as an attachment this time.
As with your other patch this is a base64 encoded binary so none of the
standard patch tools can apply it. I did after some hacking manage to
apply it by hand - as well as the sending issues it seemed to have been
developed against something other than current ASoC:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.37
but it's thre now.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-08-19 11:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-18 9:09 [PATCH] tlv320aic3x symmetric rates Randolph Chung
2010-08-18 9:19 ` Mark Brown
2010-08-18 12:54 ` Liam Girdwood
2010-08-18 13:00 ` Mark Brown
2010-08-19 4:23 ` Randolph Chung
2010-08-19 11:08 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.