* [PATCH] ASoC: omap: rx51: Use gpio_set_value_cansleep for speaker amp control
@ 2010-08-23 7:36 Jarkko Nikula
2010-08-23 9:58 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Nikula @ 2010-08-23 7:36 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown, Liam Girdwood
Speaker amplifier is controlled by TWL4030 GPIO which may sleep. Therefore
use gpio_set_value_cansleep to get rid of runtime warning that is introduced
after the commit 9c4ba94 and to get a stack trace if ever executing this
code in atomic context.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
---
sound/soc/omap/rx51.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/omap/rx51.c b/sound/soc/omap/rx51.c
index d1d8098..04b5723 100644
--- a/sound/soc/omap/rx51.c
+++ b/sound/soc/omap/rx51.c
@@ -146,9 +146,9 @@ static int rx51_spk_event(struct snd_soc_dapm_widget *w,
struct snd_kcontrol *k, int event)
{
if (SND_SOC_DAPM_EVENT_ON(event))
- gpio_set_value(RX51_SPEAKER_AMP_TWL_GPIO, 1);
+ gpio_set_value_cansleep(RX51_SPEAKER_AMP_TWL_GPIO, 1);
else
- gpio_set_value(RX51_SPEAKER_AMP_TWL_GPIO, 0);
+ gpio_set_value_cansleep(RX51_SPEAKER_AMP_TWL_GPIO, 0);
return 0;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: omap: rx51: Use gpio_set_value_cansleep for speaker amp control
2010-08-23 7:36 [PATCH] ASoC: omap: rx51: Use gpio_set_value_cansleep for speaker amp control Jarkko Nikula
@ 2010-08-23 9:58 ` Mark Brown
2010-08-23 11:06 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2010-08-23 9:58 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: alsa-devel, Liam Girdwood
On Mon, Aug 23, 2010 at 10:36:41AM +0300, Jarkko Nikula wrote:
> Speaker amplifier is controlled by TWL4030 GPIO which may sleep. Therefore
> use gpio_set_value_cansleep to get rid of runtime warning that is introduced
> after the commit 9c4ba94 and to get a stack trace if ever executing this
> code in atomic context.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: omap: rx51: Use gpio_set_value_cansleep for speaker amp control
2010-08-23 9:58 ` Mark Brown
@ 2010-08-23 11:06 ` Liam Girdwood
0 siblings, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-08-23 11:06 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel
On Mon, 2010-08-23 at 10:58 +0100, Mark Brown wrote:
> On Mon, Aug 23, 2010 at 10:36:41AM +0300, Jarkko Nikula wrote:
> > Speaker amplifier is controlled by TWL4030 GPIO which may sleep. Therefore
> > use gpio_set_value_cansleep to get rid of runtime warning that is introduced
> > after the commit 9c4ba94 and to get a stack trace if ever executing this
> > code in atomic context.
> >
> > Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
All 3 applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-23 11:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-23 7:36 [PATCH] ASoC: omap: rx51: Use gpio_set_value_cansleep for speaker amp control Jarkko Nikula
2010-08-23 9:58 ` Mark Brown
2010-08-23 11:06 ` Liam Girdwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.