From: Yang Gu <yang.gu@intel.com>
To: ofono@ofono.org
Subject: [PATCH] sim: Ensure to call sim_pin_check
Date: Wed, 25 Aug 2010 18:28:56 +0800 [thread overview]
Message-ID: <1282732136-7468-1-git-send-email-yang.gu@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
In current code, sim_pin_check() is called inside sim_efpl_read_cb().
However, there may be a chance it would never be called, thus the modem
won't be initialized correctly.
---
src/sim.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/sim.c b/src/sim.c
index a450b30..9bc9906 100644
--- a/src/sim.c
+++ b/src/sim.c
@@ -1380,8 +1380,6 @@ skip_efpl:
"PreferredLanguages",
DBUS_TYPE_STRING,
&sim->language_prefs);
-
- sim_pin_check(sim);
}
static void sim_iccid_read_cb(int ok, int length, int record,
@@ -1454,6 +1452,8 @@ static void sim_initialize(struct ofono_sim *sim)
ofono_sim_read(sim, SIM_EFPL_FILEID,
OFONO_SIM_FILE_STRUCTURE_TRANSPARENT,
sim_efpl_read_cb, sim);
+
+ sim_pin_check(sim);
}
static void sim_op_error(struct ofono_sim *sim)
--
1.7.0.4
next reply other threads:[~2010-08-25 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 10:28 Yang Gu [this message]
2010-08-25 13:12 ` [PATCH] sim: Ensure to call sim_pin_check Jeevaka.Badrappan
2010-08-25 13:57 ` Pekka Pessi
2010-08-25 14:41 ` Gu, Yang
2010-08-25 15:06 ` Denis Kenzior
2010-08-25 15:22 ` Gu, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282732136-7468-1-git-send-email-yang.gu@intel.com \
--to=yang.gu@intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.