From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] sim: Ensure to call sim_pin_check
Date: Wed, 25 Aug 2010 10:06:53 -0500 [thread overview]
Message-ID: <4C75318D.4070906@gmail.com> (raw)
In-Reply-To: <CE761E84DADF2947A4AF22FB8D97A4732A51663E@shsmsx501.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
Hi Yang,
> Your solution is better than mine, and might be Denis' intention of modification. Honestly, I ever thought about the change like your proposal (Actually it was the same as ppessi's patch), but I had a concern on current code. Now we read EFli and EFpl in parallel. Is it guaranteed the callback of EFli will be called before the callback of EFpl? IMO, it can't always guarantee this. If I'm correct, your solution is just half way to the final target. Maybe we need to work out a better one:)
Please note that the ofono_sim_read functions do not work in parallel.
All file operations are added to a queue and executed sequentially.
Hence we can rely on a certain order here.
Regards,
-Denis
next prev parent reply other threads:[~2010-08-25 15:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 10:28 [PATCH] sim: Ensure to call sim_pin_check Yang Gu
2010-08-25 13:12 ` Jeevaka.Badrappan
2010-08-25 13:57 ` Pekka Pessi
2010-08-25 14:41 ` Gu, Yang
2010-08-25 15:06 ` Denis Kenzior [this message]
2010-08-25 15:22 ` Gu, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C75318D.4070906@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.