* [PATCH] ASoC: soc-core: fix debugfs_pop_time file permissions
@ 2010-08-27 2:34 Axel Lin
2010-08-27 12:25 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2010-08-27 2:34 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown
I think this is a typo, debugfs_pop_time should not be executable.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/soc-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 65352c7..42542e0 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -249,7 +249,7 @@ static void soc_init_codec_debugfs(struct snd_soc_codec *codec)
printk(KERN_WARNING
"ASoC: Failed to create codec register debugfs file\n");
- codec->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0744,
+ codec->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0644,
codec->debugfs_codec_root,
&codec->pop_time);
if (!codec->debugfs_pop_time)
--
1.7.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: soc-core: fix debugfs_pop_time file permissions
2010-08-27 2:34 [PATCH] ASoC: soc-core: fix debugfs_pop_time file permissions Axel Lin
@ 2010-08-27 12:25 ` Liam Girdwood
2010-08-27 19:01 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Liam Girdwood @ 2010-08-27 12:25 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Mark Brown
On Fri, 2010-08-27 at 10:34 +0800, Axel Lin wrote:
> I think this is a typo, debugfs_pop_time should not be executable.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/soc-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 65352c7..42542e0 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -249,7 +249,7 @@ static void soc_init_codec_debugfs(struct snd_soc_codec *codec)
> printk(KERN_WARNING
> "ASoC: Failed to create codec register debugfs file\n");
>
> - codec->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0744,
> + codec->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0644,
> codec->debugfs_codec_root,
> &codec->pop_time);
> if (!codec->debugfs_pop_time)
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: soc-core: fix debugfs_pop_time file permissions
2010-08-27 12:25 ` Liam Girdwood
@ 2010-08-27 19:01 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-08-27 19:01 UTC (permalink / raw)
To: Liam Girdwood; +Cc: Axel Lin, linux-kernel
On Fri, Aug 27, 2010 at 01:25:00PM +0100, Liam Girdwood wrote:
> On Fri, 2010-08-27 at 10:34 +0800, Axel Lin wrote:
> > I think this is a typo, debugfs_pop_time should not be executable.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-27 19:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-27 2:34 [PATCH] ASoC: soc-core: fix debugfs_pop_time file permissions Axel Lin
2010-08-27 12:25 ` Liam Girdwood
2010-08-27 19:01 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.