From: "Dr. Michael Lauer" <mickey@vanille-media.de>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [RFC] review process
Date: Fri, 27 Aug 2010 14:37:59 +0200 [thread overview]
Message-ID: <1282912679.1860.9.camel@jupiter> (raw)
In-Reply-To: <AANLkTin5LRCz6PU_x6Mw+V2Xf8W=i+n4RLqQjwON1R7+@mail.gmail.com>
Am Freitag, den 27.08.2010, 14:15 +0200 schrieb Frans Meulenbroeks:
> 1. If a patch does not get any review feedback in X weeks time; it is
> ok to apply it. People who need more time to review a patch can
> mention that in a short reply. In that case they are granted Y more
> weeks to review.
> (suggestion: X = Y = 2)
> 2. If someone NAKs a patch it is obligatory to provide an explanation
> why the patch is not good.
> Rationale is that
> a) people can fix the problem seen by the reviewer
> b) people learn from it
> c) if there is a disagreement it can be discussed (and if needed
> raised to the TSC)
> 3) NAKs that are not motivated/explained can be ignored as not given.
>
> Your feedback, suggestions, additions, amendments, whatever is appreciated.
I agree with that. If someone does the work to create a patch he thinks
is worthwhile to apply the least we can do when NAKing is to explain why
it is not a good idea.
:M:
next prev parent reply other threads:[~2010-08-27 12:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 12:15 [RFC] review process Frans Meulenbroeks
2010-08-27 12:24 ` Graeme Gregory
2010-08-27 12:29 ` Gary Thomas
2010-08-27 12:33 ` Frans Meulenbroeks
2010-08-27 12:37 ` Dr. Michael Lauer [this message]
2010-08-27 13:46 ` Execution of Build Output Failing (Testing) openembedded
2010-08-27 17:41 ` Khem Raj
2010-08-27 19:37 ` openembedded
2010-08-27 15:11 ` [RFC] review process Roman I Khimov
2010-08-28 10:25 ` Koen Kooi
2010-08-28 12:17 ` Frans Meulenbroeks
2010-09-06 18:54 ` Frans Meulenbroeks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282912679.1860.9.camel@jupiter \
--to=mickey@vanille-media.de \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.