All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman I Khimov <roman@khimov.ru>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [RFC] review process
Date: Fri, 27 Aug 2010 19:11:46 +0400	[thread overview]
Message-ID: <201008271911.49376.roman@khimov.ru> (raw)
In-Reply-To: <AANLkTin5LRCz6PU_x6Mw+V2Xf8W=i+n4RLqQjwON1R7+@mail.gmail.com>

[-- Attachment #1: Type: Text/Plain, Size: 983 bytes --]

В сообщении от Пятница 27 августа 2010 16:15:01 автор Frans Meulenbroeks 
написал:
> 1. If a patch does not get any review feedback in X weeks time; it is
> ok to apply it. People who need more time to review a patch can
> mention that in a short reply. In that case they are granted Y more
> weeks to review.
> (suggestion: X = Y = 2)
> 2. If someone NAKs a patch it is obligatory to provide an explanation
> why the patch is not good.
> Rationale is that
> a) people can fix the problem seen by the reviewer
> b) people learn from it
> c) if there is a disagreement it can be discussed (and if needed
> raised to the TSC)
> 3) NAKs that are not motivated/explained can be ignored as not given.

Looks good to me, especially the first one as some defined period of time to 
wait is useful. Two weeks is OK.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  parent reply	other threads:[~2010-08-27 15:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-27 12:15 [RFC] review process Frans Meulenbroeks
2010-08-27 12:24 ` Graeme Gregory
2010-08-27 12:29   ` Gary Thomas
2010-08-27 12:33     ` Frans Meulenbroeks
2010-08-27 12:37 ` Dr. Michael Lauer
2010-08-27 13:46 ` Execution of Build Output Failing (Testing) openembedded
2010-08-27 17:41   ` Khem Raj
2010-08-27 19:37     ` openembedded
2010-08-27 15:11 ` Roman I Khimov [this message]
2010-08-28 10:25 ` [RFC] review process Koen Kooi
2010-08-28 12:17   ` Frans Meulenbroeks
2010-09-06 18:54     ` Frans Meulenbroeks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008271911.49376.roman@khimov.ru \
    --to=roman@khimov.ru \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.