All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] safe_macros: match oldlib SAFE_CLOSE with docs
Date: Tue, 12 Jul 2016 12:10:58 -0400 (EDT)	[thread overview]
Message-ID: <1283099046.4208400.1468339858052.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160712135542.GD2651@rei.suse.cz>





----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Tuesday, 12 July, 2016 3:55:43 PM
> Subject: Re: [LTP] [PATCH] safe_macros: match oldlib SAFE_CLOSE with docs
> 
> Hi!
> > Docs say that SAFE_CLOSE() sets the passed file descriptor to -1
> > after it's successfully closed, but oldlib SAFE_CLOSE doesn't
> > do that.
> 
> Have you tried to run at least syscalls testsuite after this change?

That was the plan, but I didn't get to that today.

I was thinking syscalls as well, since most common failure seems
to be errno tests, trying to trigger EBADF, etc.

I'll reply once I have results.

Regards,
Jan

> 
> I do not expect that this will break anything, but there it's a possibility.
> 
> --
> Cyril Hrubis
> chrubis@suse.cz
> 

  reply	other threads:[~2016-07-12 16:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11 14:29 [LTP] [PATCH] safe_macros: match oldlib SAFE_CLOSE with docs Jan Stancek
2016-07-12 13:55 ` Cyril Hrubis
2016-07-12 16:10   ` Jan Stancek [this message]
2016-07-13 12:52     ` Jan Stancek
2016-07-13 12:51       ` Cyril Hrubis
2016-07-13 13:20         ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283099046.4208400.1468339858052.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.