From: Maxim Levitsky <maximlevitsky@gmail.com>
To: lirc-list@lists.sourceforge.net
Cc: Jarod Wilson <jarod@wilsonet.com>,
linux-input@vger.kernel.org, linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Christoph Bartelmus <lirc@bartelmus.de>,
Maxim Levitsky <maximlevitsky@gmail.com>
Subject: [PATCH 4/7] IR: fix keys beeing stuck down forever.
Date: Mon, 30 Aug 2010 11:52:24 +0300 [thread overview]
Message-ID: <1283158348-7429-5-git-send-email-maximlevitsky@gmail.com> (raw)
In-Reply-To: <1283158348-7429-1-git-send-email-maximlevitsky@gmail.com>
The logic in ir_timer_keyup was inverted.
In case that values aren't equal,
the meaning of the time_is_after_eq_jiffies(ir->keyup_jiffies) is that
ir->keyup_jiffies is after the the jiffies or equally that
that jiffies are before the the ir->keyup_jiffies which is
exactly the situation we want to avoid (that the timeout is in the future)
Confusing Eh?
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
drivers/media/IR/ir-keytable.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c
index 3f0dd80..b5addb8 100644
--- a/drivers/media/IR/ir-keytable.c
+++ b/drivers/media/IR/ir-keytable.c
@@ -319,7 +319,7 @@ static void ir_timer_keyup(unsigned long cookie)
* a keyup event might follow immediately after the keydown.
*/
spin_lock_irqsave(&ir->keylock, flags);
- if (time_is_after_eq_jiffies(ir->keyup_jiffies))
+ if (time_is_before_eq_jiffies(ir->keyup_jiffies))
ir_keyup(ir);
spin_unlock_irqrestore(&ir->keylock, flags);
}
--
1.7.0.4
next prev parent reply other threads:[~2010-08-30 8:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 8:52 Many fixes for in-kernel decoding + ENE driver Maxim Levitsky
2010-08-30 8:52 ` [PATCH 1/7] IR: plug races in handling threads Maxim Levitsky
2010-08-30 8:52 ` [PATCH 2/7] IR: make sure we register input device when it safe to do so Maxim Levitsky
2010-08-30 8:52 ` [PATCH 3/7] IR: fix duty cycle capability Maxim Levitsky
2010-08-30 8:52 ` Maxim Levitsky [this message]
2010-08-30 8:52 ` [PATCH 5/7] ene_ir: updates Maxim Levitsky
2010-08-30 8:52 ` [PATCH 6/7] IR: extend ir_raw_event and do refactoring Maxim Levitsky
2010-09-02 20:56 ` David Härdeman
2010-09-02 20:56 ` David Härdeman
2010-09-02 21:20 ` Maxim Levitsky
2010-09-02 21:20 ` Maxim Levitsky
2010-09-02 22:32 ` David Härdeman
2010-09-02 22:32 ` David Härdeman
2010-08-30 8:52 ` [PATCH 7/7] ENE: add support for carrier reports Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283158348-7429-5-git-send-email-maximlevitsky@gmail.com \
--to=maximlevitsky@gmail.com \
--cc=jarod@wilsonet.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lirc-list@lists.sourceforge.net \
--cc=lirc@bartelmus.de \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.