From: "David Härdeman" <david@hardeman.nu>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: lirc-list@lists.sourceforge.net,
Jarod Wilson <jarod@wilsonet.com>,
linux-input@vger.kernel.org, linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Christoph Bartelmus <lirc@bartelmus.de>
Subject: Re: [PATCH 6/7] IR: extend ir_raw_event and do refactoring
Date: Thu, 2 Sep 2010 22:56:07 +0200 [thread overview]
Message-ID: <20100902205607.GB3886@hardeman.nu> (raw)
In-Reply-To: <1283158348-7429-7-git-send-email-maximlevitsky@gmail.com>
On Mon, Aug 30, 2010 at 11:52:26AM +0300, Maxim Levitsky wrote:
> Add new event types for timeout & carrier report
> Move timeout handling from ir_raw_event_store_with_filter to
> ir-lirc-codec, where it is really needed.
Yes, but it still might make more sense to keep the timeout handling in
ir_raw_event_store_with_filter so that all decoders get the same data
from rc-core?
> Now lirc bridge ensures proper gap handling.
> Extend lirc bridge for carrier & timeout reports
>
> Note: all new ir_raw_event variables now should be initialized
> like that:
> struct ir_raw_event ev = ir_new_event;
Wouldn't DEFINE_RAW_EVENT(ev); be more in line with the kernel coding
style? (cf. DEFINE_MUTEX, DEFINE_SPINLOCK, etc).
--
David Härdeman
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "David Härdeman" <david@hardeman.nu>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: lirc-list@lists.sourceforge.net,
Jarod Wilson <jarod@wilsonet.com>,
linux-input@vger.kernel.org, linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Christoph Bartelmus <lirc@bartelmus.de>
Subject: Re: [PATCH 6/7] IR: extend ir_raw_event and do refactoring
Date: Thu, 2 Sep 2010 22:56:07 +0200 [thread overview]
Message-ID: <20100902205607.GB3886@hardeman.nu> (raw)
In-Reply-To: <1283158348-7429-7-git-send-email-maximlevitsky@gmail.com>
On Mon, Aug 30, 2010 at 11:52:26AM +0300, Maxim Levitsky wrote:
> Add new event types for timeout & carrier report
> Move timeout handling from ir_raw_event_store_with_filter to
> ir-lirc-codec, where it is really needed.
Yes, but it still might make more sense to keep the timeout handling in
ir_raw_event_store_with_filter so that all decoders get the same data
from rc-core?
> Now lirc bridge ensures proper gap handling.
> Extend lirc bridge for carrier & timeout reports
>
> Note: all new ir_raw_event variables now should be initialized
> like that:
> struct ir_raw_event ev = ir_new_event;
Wouldn't DEFINE_RAW_EVENT(ev); be more in line with the kernel coding
style? (cf. DEFINE_MUTEX, DEFINE_SPINLOCK, etc).
--
David Härdeman
next prev parent reply other threads:[~2010-09-02 20:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 8:52 Many fixes for in-kernel decoding + ENE driver Maxim Levitsky
2010-08-30 8:52 ` [PATCH 1/7] IR: plug races in handling threads Maxim Levitsky
2010-08-30 8:52 ` [PATCH 2/7] IR: make sure we register input device when it safe to do so Maxim Levitsky
2010-08-30 8:52 ` [PATCH 3/7] IR: fix duty cycle capability Maxim Levitsky
2010-08-30 8:52 ` [PATCH 4/7] IR: fix keys beeing stuck down forever Maxim Levitsky
2010-08-30 8:52 ` [PATCH 5/7] ene_ir: updates Maxim Levitsky
2010-08-30 8:52 ` [PATCH 6/7] IR: extend ir_raw_event and do refactoring Maxim Levitsky
2010-09-02 20:56 ` David Härdeman [this message]
2010-09-02 20:56 ` David Härdeman
2010-09-02 21:20 ` Maxim Levitsky
2010-09-02 21:20 ` Maxim Levitsky
2010-09-02 22:32 ` David Härdeman
2010-09-02 22:32 ` David Härdeman
2010-08-30 8:52 ` [PATCH 7/7] ENE: add support for carrier reports Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902205607.GB3886@hardeman.nu \
--to=david@hardeman.nu \
--cc=jarod@wilsonet.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lirc-list@lists.sourceforge.net \
--cc=lirc@bartelmus.de \
--cc=maximlevitsky@gmail.com \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.