From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [Uclinux-dist-devel] [PATCH] mtd: Blackfin NFC: fix invalid free in remove()
Date: Mon, 30 Aug 2010 18:10:47 +0300 [thread overview]
Message-ID: <1283181047.2005.1.camel@brekeke> (raw)
In-Reply-To: <AANLkTikE93Uqnf7_8p72rEhcRydmx0LdBVCM_z3tNr-z@mail.gmail.com>
On Mon, 2010-08-30 at 09:32 -0400, Mike Frysinger wrote:
> On Mon, Aug 30, 2010 at 08:59, Artem Bityutskiy wrote:
> > On Mon, 2010-08-30 at 15:58 +0300, Artem Bityutskiy wrote:
> >> On Sat, 2010-08-28 at 16:42 -0400, Mike Frysinger wrote:
> >> > Since info->mtd isn't dynamically allocated, we shouldn't attempt to
> >> > kfree() it. Otherwise we get random fun corruption when unloading
> >> > the driver built as a module.
> >> >
> >> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> >> > ---
> >> > note: this should be merged for 2.6.36 and probably sent to stable trees
> >>
> >> You send the same patch 2 times once with this note and the other time
> >> without this note. Which one should be ignored?
> >
> > I guess it is 2.6.36 material. Also, if you want this in -stable, add
> > corresponding CC please.
>
> once it gets merged, then i can notify the stable guys
AFAIK, this is not the way they prefer to work. The right protocol is
that you add 'Cc: stable@kernel.org' to the commit message, ane they
pick the patch. I might be mistaken, but AFAIK this is the way.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH] mtd: Blackfin NFC: fix invalid free in remove()
Date: Mon, 30 Aug 2010 18:10:47 +0300 [thread overview]
Message-ID: <1283181047.2005.1.camel@brekeke> (raw)
In-Reply-To: <AANLkTikE93Uqnf7_8p72rEhcRydmx0LdBVCM_z3tNr-z@mail.gmail.com>
On Mon, 2010-08-30 at 09:32 -0400, Mike Frysinger wrote:
> On Mon, Aug 30, 2010 at 08:59, Artem Bityutskiy wrote:
> > On Mon, 2010-08-30 at 15:58 +0300, Artem Bityutskiy wrote:
> >> On Sat, 2010-08-28 at 16:42 -0400, Mike Frysinger wrote:
> >> > Since info->mtd isn't dynamically allocated, we shouldn't attempt to
> >> > kfree() it. Otherwise we get random fun corruption when unloading
> >> > the driver built as a module.
> >> >
> >> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> >> > ---
> >> > note: this should be merged for 2.6.36 and probably sent to stable trees
> >>
> >> You send the same patch 2 times once with this note and the other time
> >> without this note. Which one should be ignored?
> >
> > I guess it is 2.6.36 material. Also, if you want this in -stable, add
> > corresponding CC please.
>
> once it gets merged, then i can notify the stable guys
AFAIK, this is not the way they prefer to work. The right protocol is
that you add 'Cc: stable@kernel.org' to the commit message, ane they
pick the patch. I might be mistaken, but AFAIK this is the way.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2010-08-30 15:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 20:42 [PATCH] mtd: Blackfin NFC: fix invalid free in remove() Mike Frysinger
2010-08-28 20:42 ` Mike Frysinger
2010-08-28 20:42 ` Mike Frysinger
2010-08-28 20:42 ` Mike Frysinger
2010-08-30 12:58 ` Artem Bityutskiy
2010-08-30 12:58 ` Artem Bityutskiy
2010-08-30 12:59 ` Artem Bityutskiy
2010-08-30 12:59 ` Artem Bityutskiy
2010-08-30 13:32 ` [Uclinux-dist-devel] " Mike Frysinger
2010-08-30 13:32 ` Mike Frysinger
2010-08-30 15:10 ` Artem Bityutskiy [this message]
2010-08-30 15:10 ` Artem Bityutskiy
2010-08-30 15:14 ` Mike Frysinger
2010-08-30 13:31 ` Mike Frysinger
2010-08-30 13:31 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283181047.2005.1.camel@brekeke \
--to=dedekind1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.