From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jonathan Haws <Jonathan.Haws@sdl.usu.edu>
Cc: "linux-net@vger.kernel.org" <linux-net@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: Memory allocation modifications in ibm_newemac driver
Date: Thu, 02 Sep 2010 14:18:12 +1000 [thread overview]
Message-ID: <1283401092.16240.8.camel@pasglop> (raw)
In-Reply-To: <5ABE8A5E96C0364CAF2B4DC1DEB7CEAC127A301B@Mercury.usurf.usu.edu>
On Wed, 2010-09-01 at 22:04 +0000, Jonathan Haws wrote:
> Okay, I think I have all the issues worked out and can now send and
> receive any size packet without a hiccup. I have tested this in our
> system setup as well with data being sent out to disk and did not see
> any problems there either (since it only ever allocates a single page,
> never more).
>
> Is this something that may be wanted in the mainline? I have not run
> full benchmarks, but I anticipate that my modified driver is slightly
> slower than the mainline driver because we keep track of an SKB ring,
> as well as a ring of pages and allocate both on each packet received.
Well, it won't hurt to post the patch to review :-)
Make sure to CC me as I more/less maintain that driver.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jonathan Haws <Jonathan.Haws@sdl.usu.edu>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-net@vger.kernel.org" <linux-net@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: RE: Memory allocation modifications in ibm_newemac driver
Date: Thu, 02 Sep 2010 14:18:12 +1000 [thread overview]
Message-ID: <1283401092.16240.8.camel@pasglop> (raw)
In-Reply-To: <5ABE8A5E96C0364CAF2B4DC1DEB7CEAC127A301B@Mercury.usurf.usu.edu>
On Wed, 2010-09-01 at 22:04 +0000, Jonathan Haws wrote:
> Okay, I think I have all the issues worked out and can now send and
> receive any size packet without a hiccup. I have tested this in our
> system setup as well with data being sent out to disk and did not see
> any problems there either (since it only ever allocates a single page,
> never more).
>
> Is this something that may be wanted in the mainline? I have not run
> full benchmarks, but I anticipate that my modified driver is slightly
> slower than the mainline driver because we keep track of an SKB ring,
> as well as a ring of pages and allocate both on each packet received.
Well, it won't hurt to post the patch to review :-)
Make sure to CC me as I more/less maintain that driver.
Cheers,
Ben.
next prev parent reply other threads:[~2010-09-02 4:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 20:41 Memory allocation modifications in ibm_newemac driver Jonathan Haws
2010-09-01 21:18 ` Jonathan Haws
2010-09-01 21:18 ` Jonathan Haws
2010-09-01 22:04 ` Jonathan Haws
2010-09-01 22:04 ` Jonathan Haws
2010-09-01 22:46 ` Jonathan Haws
2010-09-01 22:46 ` Jonathan Haws
2010-09-02 4:18 ` Benjamin Herrenschmidt
2010-09-02 4:18 ` Benjamin Herrenschmidt
2010-09-02 15:54 ` Memory allocation modifications in ibm_newemac driver AND sil24 driver Jonathan Haws
2010-09-02 15:54 ` Jonathan Haws
2010-09-02 4:18 ` Benjamin Herrenschmidt [this message]
2010-09-02 4:18 ` Memory allocation modifications in ibm_newemac driver Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283401092.16240.8.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Jonathan.Haws@sdl.usu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.