From: Peter Zijlstra <peterz@infradead.org>
To: Paul Turner <pjt@google.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Chris Friesen <cfriesen@nortel.com>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Pierre Bourdon <pbourdon@excellency.fr>
Subject: Re: [RFC][PATCH 2/3] sched: On-demand cfs_rq list
Date: Fri, 03 Sep 2010 09:59:29 +0200 [thread overview]
Message-ID: <1283500769.1783.134.camel@laptop> (raw)
In-Reply-To: <AANLkTineCQ=7wt_ErN6sw5TP1z2Yp1Gvoo0Y0jyp7Gjq@mail.gmail.com>
On Fri, 2010-09-03 at 04:33 +0100, Paul Turner wrote:
> > @@ -668,6 +693,11 @@ static void update_cfs_load(struct cfs_r
> > cfs_rq->load_period /= 2;
> > cfs_rq->load_avg /= 2;
> > }
> > +
> > + if (lb && !cfs_rq->nr_running) {
> > + if (cfs_rq->load_period < (period / 8))
> > + list_del_leaf_cfs_rq(cfs_rq);
> > + }
> > }
> >
>
> In the case of zero load, load_avg above will decay however
> load_period will remain in the range [period/2, period], any entity
> that has passed period/8 time will remain on the leaf rq list.
Right, already changed that to cfs_rq->load_avg < (period / 8) after you
pointed that out on irc..
> The lb condition could also be relaxed in the dequeue_entity case.
>
Possibly yeah, we'll have to see if that makes much difference.
next prev parent reply other threads:[~2010-09-03 8:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 22:30 [RFC][PATCH 0/3] Try and make cpu-cgroup suck less Peter Zijlstra
2010-08-28 22:30 ` [RFC][PATCH 1/3] sched: Rewrite tg_shares_up Peter Zijlstra
2010-08-30 17:20 ` Srivatsa Vaddagiri
2010-08-30 17:53 ` Peter Zijlstra
2010-09-03 3:09 ` Paul Turner
2010-09-03 7:59 ` Peter Zijlstra
2010-08-28 22:30 ` [RFC][PATCH 2/3] sched: On-demand cfs_rq list Peter Zijlstra
2010-09-03 3:33 ` Paul Turner
2010-09-03 7:59 ` Peter Zijlstra [this message]
2010-08-28 22:30 ` [RFC][PATCH 3/3] sched: On-demand tg_shares_up() Peter Zijlstra
2010-09-03 1:52 ` Paul Turner
2010-09-03 7:59 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283500769.1783.134.camel@laptop \
--to=peterz@infradead.org \
--cc=cfriesen@nortel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pbourdon@excellency.fr \
--cc=pjt@google.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.