[PATCH 1/2] java-library.bbclass: do_stage is not needed anymore

[PATCH 1/2] java-library.bbclass: do_stage is not needed anymore

[Khem Raj]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 classes/java-library.bbclass |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
index 904b4f1..5ce0537 100644
--- a/classes/java-library.bbclass
+++ b/classes/java-library.bbclass
@@ -65,7 +65,3 @@ do_install() {
 java_stage() {
   oe_jarinstall -s ${JARFILENAME} ${ALTJARFILENAMES}
 }
-
-do_stage() {
-  java_stage
-}
-- 
1.7.1

[PATCH 2/2] jaxme_0.5.2.bb, xpp3_1.1.3.4.O.bb: Remove do_stage_append

[Khem Raj]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 recipes/xml-commons/jaxme_0.5.2.bb    |    7 -------
 recipes/xml-commons/xpp3_1.1.3.4.O.bb |    4 ----
 2 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/recipes/xml-commons/jaxme_0.5.2.bb b/recipes/xml-commons/jaxme_0.5.2.bb
index 4fa9cdf..304c06d 100644
--- a/recipes/xml-commons/jaxme_0.5.2.bb
+++ b/recipes/xml-commons/jaxme_0.5.2.bb
@@ -39,13 +39,6 @@ do_install_append() {
 	oe_jarinstall jaxmepm-${PV}.jar jaxmepm.jar
 }
 
-do_stage_append() {
-	oe_jarinstall -s jaxmeapi-${PV}.jar jaxmeapi.jar
-	oe_jarinstall -s jaxmejs-${PV}.jar jaxmejs.jar
-	oe_jarinstall -s jaxmexs-${PV}.jar jaxmexs.jar
-	oe_jarinstall -s jaxmepm-${PV}.jar jaxmepm.jar
-}
-
 # Compile helper
 # 1 - source dir
 # 2 - dest dir
diff --git a/recipes/xml-commons/xpp3_1.1.3.4.O.bb b/recipes/xml-commons/xpp3_1.1.3.4.O.bb
index 11b82ab..40f7cb2 100644
--- a/recipes/xml-commons/xpp3_1.1.3.4.O.bb
+++ b/recipes/xml-commons/xpp3_1.1.3.4.O.bb
@@ -42,10 +42,6 @@ do_install_append() {
 	oe_jarinstall xpp3-xpath-${PV}.jar xpp3-xpath.jar
 }
 
-do_stage_append() {
-	oe_jarinstall -s xpp3-xpath-${PV}.jar xpp3-xpath.jar
-}
-
 FILES_libxpp3-xpath-java = "${datadir}/java/xpp3-xpath*"
 
 
-- 
1.7.1

Re: [PATCH 2/2] jaxme_0.5.2.bb, xpp3_1.1.3.4.O.bb: Remove do_stage_append

[Robert Schuster]

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

This as well.

Signed-off-by: Robert Schuster <robertschuster@fsfe.org>

Am 07.09.2010 09:02, schrieb Khem Raj:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  recipes/xml-commons/jaxme_0.5.2.bb    |    7 -------
>  recipes/xml-commons/xpp3_1.1.3.4.O.bb |    4 ----
>  2 files changed, 0 insertions(+), 11 deletions(-)
> 
> diff --git a/recipes/xml-commons/jaxme_0.5.2.bb b/recipes/xml-commons/jaxme_0.5.2.bb
> index 4fa9cdf..304c06d 100644
> --- a/recipes/xml-commons/jaxme_0.5.2.bb
> +++ b/recipes/xml-commons/jaxme_0.5.2.bb
> @@ -39,13 +39,6 @@ do_install_append() {
>  	oe_jarinstall jaxmepm-${PV}.jar jaxmepm.jar
>  }
>  
> -do_stage_append() {
> -	oe_jarinstall -s jaxmeapi-${PV}.jar jaxmeapi.jar
> -	oe_jarinstall -s jaxmejs-${PV}.jar jaxmejs.jar
> -	oe_jarinstall -s jaxmexs-${PV}.jar jaxmexs.jar
> -	oe_jarinstall -s jaxmepm-${PV}.jar jaxmepm.jar
> -}
> -
>  # Compile helper
>  # 1 - source dir
>  # 2 - dest dir
> diff --git a/recipes/xml-commons/xpp3_1.1.3.4.O.bb b/recipes/xml-commons/xpp3_1.1.3.4.O.bb
> index 11b82ab..40f7cb2 100644
> --- a/recipes/xml-commons/xpp3_1.1.3.4.O.bb
> +++ b/recipes/xml-commons/xpp3_1.1.3.4.O.bb
> @@ -42,10 +42,6 @@ do_install_append() {
>  	oe_jarinstall xpp3-xpath-${PV}.jar xpp3-xpath.jar
>  }
>  
> -do_stage_append() {
> -	oe_jarinstall -s xpp3-xpath-${PV}.jar xpp3-xpath.jar
> -}
> -
>  FILES_libxpp3-xpath-java = "${datadir}/java/xpp3-xpath*"
>  
>  





[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 270 bytes --]

Re: [PATCH 1/2] java-library.bbclass: do_stage is not needed anymore

[Robert Schuster]

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]

Patch is fine!

Signed-off-by: Robert Schuster <robertschuster@fsfe.org>

Am 07.09.2010 09:02, schrieb Khem Raj:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  classes/java-library.bbclass |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
> index 904b4f1..5ce0537 100644
> --- a/classes/java-library.bbclass
> +++ b/classes/java-library.bbclass
> @@ -65,7 +65,3 @@ do_install() {
>  java_stage() {
>    oe_jarinstall -s ${JARFILENAME} ${ALTJARFILENAMES}
>  }
> -
> -do_stage() {
> -  java_stage
> -}





[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 270 bytes --]

Re: [PATCH 1/2] java-library.bbclass: do_stage is not needed anymore

[Fahad]

On Tue, 2010-09-07 at 00:02 -0700, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  classes/java-library.bbclass |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
> index 904b4f1..5ce0537 100644
> --- a/classes/java-library.bbclass
> +++ b/classes/java-library.bbclass
> @@ -65,7 +65,3 @@ do_install() {
>  java_stage() {
>    oe_jarinstall -s ${JARFILENAME} ${ALTJARFILENAMES}
>  }
Shouldn't you remove this java_stage function as well, as it won't be
called anymore.
> -
> -do_stage() {
> -  java_stage
> -}

Re: [PATCH 1/2] java-library.bbclass: do_stage is not needed anymore

[Khem Raj]

On Tue, Sep 7, 2010 at 10:57 PM, Fahad <Fahad_Usman@mentor.com> wrote:
> On Tue, 2010-09-07 at 00:02 -0700, Khem Raj wrote:
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  classes/java-library.bbclass |    4 ----
>>  1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
>> index 904b4f1..5ce0537 100644
>> --- a/classes/java-library.bbclass
>> +++ b/classes/java-library.bbclass
>> @@ -65,7 +65,3 @@ do_install() {
>>  java_stage() {
>>    oe_jarinstall -s ${JARFILENAME} ${ALTJARFILENAMES}
>>  }
> Shouldn't you remove this java_stage function as well, as it won't be
> called anymore.

its still used in do_install. but yes there can be some cleanup done
there. I did
minimum to fix it.
>> -
>> -do_stage() {
>> -  java_stage
>> -}
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>