[GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Hans Verkuil]

Thanks to Hans de Goede for supplying me with a Philips webcam to test this
driver with!

And other news on the V4L1 front:

I have since learned that the stradis driver has only ever worked for kernel 2.2.
I did contact the company and unless they want to work on it this driver can be
removed soon.

I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
support can be removed from that driver as well.

Regards,

	Hans

The following changes since commit 57fef3eb74a04716a8dd18af0ac510ec4f71bc05:
  Richard Zidlicky (1):
        V4L/DVB: dvb: fix smscore_getbuffer() logic

are available in the git repository at:

  ssh://linuxtv.org/git/hverkuil/v4l-dvb.git pwc

Hans Verkuil (1):
      pwc: fully convert driver to V4L2

 drivers/media/video/pwc/Kconfig          |    2 +-
 drivers/media/video/pwc/pwc-ctrl.c       |   20 +-
 drivers/media/video/pwc/pwc-if.c         |   23 +-
 drivers/media/video/pwc/pwc-misc.c       |    4 +-
 drivers/media/video/pwc/pwc-uncompress.c |    2 +-
 drivers/media/video/pwc/pwc-v4l.c        |  322 +-----------------------------
 drivers/media/video/pwc/pwc.h            |    6 +-
 7 files changed, 40 insertions(+), 339 deletions(-)

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco

Re: [GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Andy Walls]

On Sun, 2010-09-12 at 22:26 +0200, Hans Verkuil wrote:

> And other news on the V4L1 front:

> I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
> support can be removed from that driver as well.

FYI, that will break this 2005 vintage piece of V4L1 software people may
still be using for the QX5 microscope:

http://www.cryptoforge.net/qx5/qx5view/
http://www.cryptoforge.net/qx5/qx5view/qx5view-0.5.tar.gz

The wiki page happens to mention qx5view:
http://linuxtv.org/wiki/index.php/QX5_USB_microscope


Slightly OT: The private V4L2 control for the "Lights" in cpia2_v4l.c
could be changed to Illuminator [12] for the QX5 microscope.

Regards,
Andy

Re: [GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Andy Walls]

On Sun, 2010-09-12 at 17:12 -0400, Andy Walls wrote:
> On Sun, 2010-09-12 at 22:26 +0200, Hans Verkuil wrote:
> 
> > And other news on the V4L1 front:
> 
> > I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
> > support can be removed from that driver as well.
> 
> FYI, that will break this 2005 vintage piece of V4L1 software people may
> still be using for the QX5 microscope:

Sorry, that is of course, if there is no V4L1 compat layer still in
place.

BTW, qx5view uses a private ioctl() to change the lights on a QX5 and
not the V4L2 control.

In qx5view:

void setlight() {
#define CPIA2_IOC_SET_GPIO         _IOR('v', BASE_VIDIOCPRIVATE + 17, __u32)
    ioctl(dev, CPIA2_IOC_SET_GPIO, light_setting);
}


In the cpia2 driver:

       /* CPIA2 extension to Video4Linux API */
        case CPIA2_IOC_SET_GPIO:
                retval = ioctl_set_gpio(arg, cam);
                break;

Yuck.

Regards,
Andy

Re: [GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Andy Walls]

On Sun, 2010-09-12 at 17:28 -0400, Andy Walls wrote:
> On Sun, 2010-09-12 at 17:12 -0400, Andy Walls wrote:
> > On Sun, 2010-09-12 at 22:26 +0200, Hans Verkuil wrote:
> > 
> > > And other news on the V4L1 front:
> > 
> > > I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
> > > support can be removed from that driver as well.
> > 


> In the cpia2 driver:
> 
>        /* CPIA2 extension to Video4Linux API */
>         case CPIA2_IOC_SET_GPIO:
>                 retval = ioctl_set_gpio(arg, cam);
>                 break;
> 
> Yuck.

And another gem in the cpia2 driver, this V4L2 control:


        {
                .id            = CPIA2_CID_GPIO,
                .type          = V4L2_CTRL_TYPE_INTEGER,
                .name          = "GPIO",
                .minimum       = 0,
                .maximum       = 255,
                .step          = 1,
                .default_value = 0,
        },

Give me a GUI with a slider for that control, and I'm sure I can fry a
camera.

That should be removed.

Regards,
Andy

Re: [GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Mauro Carvalho Chehab]

Em 12-09-2010 18:28, Andy Walls escreveu:
> On Sun, 2010-09-12 at 17:12 -0400, Andy Walls wrote:
>> On Sun, 2010-09-12 at 22:26 +0200, Hans Verkuil wrote:
>>
>>> And other news on the V4L1 front:
>>
>>> I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
>>> support can be removed from that driver as well.
>>
>> FYI, that will break this 2005 vintage piece of V4L1 software people may
>> still be using for the QX5 microscope:
> 
> Sorry, that is of course, if there is no V4L1 compat layer still in
> place.
> 
> BTW, qx5view uses a private ioctl() to change the lights on a QX5 and
> not the V4L2 control.

The better would be to port qx5view to use libv4l and implement the new
illuminator ctrl on the driver and on the userspase app. Do you have
hardware for testing this?

> 
> In qx5view:
> 
> void setlight() {
> #define CPIA2_IOC_SET_GPIO         _IOR('v', BASE_VIDIOCPRIVATE + 17, __u32)
>     ioctl(dev, CPIA2_IOC_SET_GPIO, light_setting);
> }
> 
> 
> In the cpia2 driver:
> 
>        /* CPIA2 extension to Video4Linux API */
>         case CPIA2_IOC_SET_GPIO:
>                 retval = ioctl_set_gpio(arg, cam);
>                 break;
> 
> Yuck.
> 
> Regards,
> Andy
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Andy Walls]

On Mon, 2010-09-13 at 08:27 -0300, Mauro Carvalho Chehab wrote:
> Em 12-09-2010 18:28, Andy Walls escreveu:
> > On Sun, 2010-09-12 at 17:12 -0400, Andy Walls wrote:
> >> On Sun, 2010-09-12 at 22:26 +0200, Hans Verkuil wrote:
> >>
> >>> And other news on the V4L1 front:
> >>
> >>> I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
> >>> support can be removed from that driver as well.
> >>
> >> FYI, that will break this 2005 vintage piece of V4L1 software people may
> >> still be using for the QX5 microscope:
> > 
> > Sorry, that is of course, if there is no V4L1 compat layer still in
> > place.
> > 
> > BTW, qx5view uses a private ioctl() to change the lights on a QX5 and
> > not the V4L2 control.
> 
> The better would be to port qx5view to use libv4l and implement the new
> illuminator ctrl on the driver and on the userspase app. Do you have
> hardware for testing this?

No.  I did check Amazon.com and eBay and saw a QX5 for about US$75 after
shipping costs:

http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&item=380262406989&rvr_id=139147359954&crlp=1_263602_263622&UA=L*F%3F&GUID=0b3b537412b0a0e203e63006ff9becb0&itemid=380262406989&ff4=263602_263622

I'm not sure if I want to buy one at that price, since I already have a
QX3.

Regards,
Andy

Re: [GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Thomas Kaiser]

On 09/13/2010 03:30 PM, Andy Walls wrote:
> On Mon, 2010-09-13 at 08:27 -0300, Mauro Carvalho Chehab wrote:
>> Em 12-09-2010 18:28, Andy Walls escreveu:
>>> On Sun, 2010-09-12 at 17:12 -0400, Andy Walls wrote:
>>>> On Sun, 2010-09-12 at 22:26 +0200, Hans Verkuil wrote:
>>>>
>>>>> And other news on the V4L1 front:
>>>>
>>>>> I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
>>>>> support can be removed from that driver as well.
>>>>
>>>> FYI, that will break this 2005 vintage piece of V4L1 software people may
>>>> still be using for the QX5 microscope:
>>>
>>> Sorry, that is of course, if there is no V4L1 compat layer still in
>>> place.
>>>
>>> BTW, qx5view uses a private ioctl() to change the lights on a QX5 and
>>> not the V4L2 control.
>>
>> The better would be to port qx5view to use libv4l and implement the new
>> illuminator ctrl on the driver and on the userspase app. Do you have
>> hardware for testing this?
>
> No.  I did check Amazon.com and eBay and saw a QX5 for about US$75 after
> shipping costs:
>
> http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&item=380262406989&rvr_id=139147359954&crlp=1_263602_263622&UA=L*F%3F&GUID=0b3b537412b0a0e203e63006ff9becb0&itemid=380262406989&ff4=263602_263622
>
> I'm not sure if I want to buy one at that price, since I already have a
> QX3.
>
> Regards,
> Andy
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hello Andy, Mauro

I own a USB Microscope which looks quite the same as the one in your 
link, but I don't know if it is similar to the QX3 or QX5.
It is called "Traveler USB-Mikroskop" and model number is "SU 1071".
One of this two:
http://www.traveler-service.de/cms/index.php?id=traveler-optische-geraete-de

USB ID: 1871:01b0 Aveo Technology Corp.

It is not working in Ubuntu 10.04, kernel AMD64 2.6.32-24-generic.

If it is a QX5, I can help testing.

Regards,
Thomas

Re: [GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Hans Verkuil]

On Sunday, September 12, 2010 23:12:42 Andy Walls wrote:
> On Sun, 2010-09-12 at 22:26 +0200, Hans Verkuil wrote:
> 
> > And other news on the V4L1 front:
> 
> > I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
> > support can be removed from that driver as well.
> 
> FYI, that will break this 2005 vintage piece of V4L1 software people may
> still be using for the QX5 microscope:
> 
> http://www.cryptoforge.net/qx5/qx5view/
> http://www.cryptoforge.net/qx5/qx5view/qx5view-0.5.tar.gz

Why? qx5view has support for v4l2 as well.

Regards,

	Hans

> 
> The wiki page happens to mention qx5view:
> http://linuxtv.org/wiki/index.php/QX5_USB_microscope
> 
> 
> Slightly OT: The private V4L2 control for the "Lights" in cpia2_v4l.c
> could be changed to Illuminator [12] for the QX5 microscope.
> 
> Regards,
> Andy
> 
> 
> 

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco

Re: [GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Andy Walls]

On Mon, 2010-09-13 at 09:02 +0200, Hans Verkuil wrote:
> On Sunday, September 12, 2010 23:12:42 Andy Walls wrote:
> > On Sun, 2010-09-12 at 22:26 +0200, Hans Verkuil wrote:
> > 
> > > And other news on the V4L1 front:
> > 
> > > I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
> > > support can be removed from that driver as well.
> > 
> > FYI, that will break this 2005 vintage piece of V4L1 software people may
> > still be using for the QX5 microscope:
> > 
> > http://www.cryptoforge.net/qx5/qx5view/
> > http://www.cryptoforge.net/qx5/qx5view/qx5view-0.5.tar.gz
> 
> Why? qx5view has support for v4l2 as well.

The frontend.c file in the tar archive used these ioctls:

VIDIOCSYNC
VIDIOCSPICT
VIDIOCMCAPTURE
VIDIOCSWIN
VIDIOCGCAP
VIDIOCGWIN
VIDIOCGMBUF

I could have sworn those were V4L1.  But in any case, I forgot we have a
V4L1 compat layer in place.

Please disregard.

I apparently need to spend spend more time reading and testing to get my
fact straight lately, and less time clicking the send button on
emails. :P

Regards,
Andy

Re: [GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Hans Verkuil]

On Monday, September 13, 2010 14:56:35 Andy Walls wrote:
> On Mon, 2010-09-13 at 09:02 +0200, Hans Verkuil wrote:
> > On Sunday, September 12, 2010 23:12:42 Andy Walls wrote:
> > > On Sun, 2010-09-12 at 22:26 +0200, Hans Verkuil wrote:
> > > 
> > > > And other news on the V4L1 front:
> > > 
> > > > I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
> > > > support can be removed from that driver as well.
> > > 
> > > FYI, that will break this 2005 vintage piece of V4L1 software people may
> > > still be using for the QX5 microscope:
> > > 
> > > http://www.cryptoforge.net/qx5/qx5view/
> > > http://www.cryptoforge.net/qx5/qx5view/qx5view-0.5.tar.gz
> > 
> > Why? qx5view has support for v4l2 as well.
> 
> The frontend.c file in the tar archive used these ioctls:
> 
> VIDIOCSYNC
> VIDIOCSPICT
> VIDIOCMCAPTURE
> VIDIOCSWIN
> VIDIOCGCAP
> VIDIOCGWIN
> VIDIOCGMBUF
> 
> I could have sworn those were V4L1.  But in any case, I forgot we have a
> V4L1 compat layer in place.

True, but there is also a HAVE_V4L2 define that enables v4l2 support. Whether
it works is another matter :-)

In any case, if this is a really useful application, then we can add it to
git. Or enhance e.g. qv4l2 to be able to handle this gracefully.

Regards,

	Hans

> 
> Please disregard.
> 
> I apparently need to spend spend more time reading and testing to get my
> fact straight lately, and less time clicking the send button on
> emails. :P
> 
> Regards,
> Andy
> 
> 
> 

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco

Re: [GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Hans Verkuil]

On Sunday, September 12, 2010 22:26:11 Hans Verkuil wrote:
> Thanks to Hans de Goede for supplying me with a Philips webcam to test this
> driver with!
> 
> And other news on the V4L1 front:
> 
> I have since learned that the stradis driver has only ever worked for kernel 2.2.
> I did contact the company and unless they want to work on it this driver can be
> removed soon.
> 
> I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
> support can be removed from that driver as well.
> 
> Regards,
> 
> 	Hans
> 
> The following changes since commit 57fef3eb74a04716a8dd18af0ac510ec4f71bc05:
>   Richard Zidlicky (1):
>         V4L/DVB: dvb: fix smscore_getbuffer() logic
> 
> are available in the git repository at:
> 
>   ssh://linuxtv.org/git/hverkuil/v4l-dvb.git pwc
> 
> Hans Verkuil (1):
>       pwc: fully convert driver to V4L2

As requested by Mauro I also added:

      pwc: remove BKL

Tested with the Philips webcam.

Regards,

	Hans

> 
>  drivers/media/video/pwc/Kconfig          |    2 +-
>  drivers/media/video/pwc/pwc-ctrl.c       |   20 +-
>  drivers/media/video/pwc/pwc-if.c         |   23 +-
>  drivers/media/video/pwc/pwc-misc.c       |    4 +-
>  drivers/media/video/pwc/pwc-uncompress.c |    2 +-
>  drivers/media/video/pwc/pwc-v4l.c        |  322 +-----------------------------
>  drivers/media/video/pwc/pwc.h            |    6 +-
>  7 files changed, 40 insertions(+), 339 deletions(-)
> 
> 

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco

Re: [GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Andy Walls]

The cpia2 driver doesn't know about those usb ids.

The Traveler microscopes look mechanically similar to the QX3 and QX5, but the pixel resolution is higher than the QX3.
The QX5 has the same pxiel resolution as the Traveler Mod 1, but the Mod 2 support a higher resolution.

Given all that, I'm not sure we could use your unit for regression testing of changes to the cpia2 driver.  It may be possible to support the Travveler under linux eventually, but at a minimum you'll need to provide information on the chips used in the unit.

Thanks for the offer of help.

Regards,
Andy


Thomas Kaiser <linux-dvb@kaiser-linux.li> wrote:

>On 09/13/2010 03:30 PM, Andy Walls wrote:
>> On Mon, 2010-09-13 at 08:27 -0300, Mauro Carvalho Chehab wrote:
>>> Em 12-09-2010 18:28, Andy Walls escreveu:
>>>> On Sun, 2010-09-12 at 17:12 -0400, Andy Walls wrote:
>>>>> On Sun, 2010-09-12 at 22:26 +0200, Hans Verkuil wrote:
>>>>>
>>>>>> And other news on the V4L1 front:
>>>>>
>>>>>> I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
>>>>>> support can be removed from that driver as well.
>>>>>
>>>>> FYI, that will break this 2005 vintage piece of V4L1 software people may
>>>>> still be using for the QX5 microscope:
>>>>
>>>> Sorry, that is of course, if there is no V4L1 compat layer still in
>>>> place.
>>>>
>>>> BTW, qx5view uses a private ioctl() to change the lights on a QX5 and
>>>> not the V4L2 control.
>>>
>>> The better would be to port qx5view to use libv4l and implement the new
>>> illuminator ctrl on the driver and on the userspase app. Do you have
>>> hardware for testing this?
>>
>> No.  I did check Amazon.com and eBay and saw a QX5 for about US$75 after
>> shipping costs:
>>
>> http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&item=380262406989&rvr_id=139147359954&crlp=1_263602_263622&UA=L*F%3F&GUID=0b3b537412b0a0e203e63006ff9becb0&itemid=380262406989&ff4=263602_263622
>>
>> I'm not sure if I want to buy one at that price, since I already have a
>> QX3.
>>
>> Regards,
>> Andy
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>Hello Andy, Mauro
>
>I own a USB Microscope which looks quite the same as the one in your 
>link, but I don't know if it is similar to the QX3 or QX5.
>It is called "Traveler USB-Mikroskop" and model number is "SU 1071".
>One of this two:
>http://www.traveler-service.de/cms/index.php?id=traveler-optische-geraete-de
>
>USB ID: 1871:01b0 Aveo Technology Corp.
>
>It is not working in Ubuntu 10.04, kernel AMD64 2.6.32-24-generic.
>
>If it is a QX5, I can help testing.
>
>Regards,
>Thomas
>
>

Re: [GIT PATCHES FOR 2.6.37] Remove V4L1 support from the pwc driver

[Andy Walls]

Further investigation reveals that the Traveler is likely a UVC based webcam microscope.  Aveotek provides controller chips to camera manufacturers and has a generic UVC driver download available for Windows.

I notice Traveler USA does not sell their microscope in the US.  I believe Mattell, Inc. owns some aspects of the mechanical design (since the sticker on the bottom of my QX3 indicates it was made by Mattell).

Regards,
Andy

Andy Walls <awalls@md.metrocast.net> wrote:

>The cpia2 driver doesn't know about those usb ids.
>
>The Traveler microscopes look mechanically similar to the QX3 and QX5, but the pixel resolution is higher than the QX3.
>The QX5 has the same pxiel resolution as the Traveler Mod 1, but the Mod 2 support a higher resolution.
>
>Given all that, I'm not sure we could use your unit for regression testing of changes to the cpia2 driver.  It may be possible to support the Travveler under linux eventually, but at a minimum you'll need to provide information on the chips used in the unit.
>
>Thanks for the offer of help.
>
>Regards,
>Andy
>
>
>Thomas Kaiser <linux-dvb@kaiser-linux.li> wrote:
>
>>On 09/13/2010 03:30 PM, Andy Walls wrote:
>>> On Mon, 2010-09-13 at 08:27 -0300, Mauro Carvalho Chehab wrote:
>>>> Em 12-09-2010 18:28, Andy Walls escreveu:
>>>>> On Sun, 2010-09-12 at 17:12 -0400, Andy Walls wrote:
>>>>>> On Sun, 2010-09-12 at 22:26 +0200, Hans Verkuil wrote:
>>>>>>
>>>>>>> And other news on the V4L1 front:
>>>>>>
>>>>>>> I'm waiting for test results on the cpia2 driver. If it works, then the V4L1
>>>>>>> support can be removed from that driver as well.
>>>>>>
>>>>>> FYI, that will break this 2005 vintage piece of V4L1 software people may
>>>>>> still be using for the QX5 microscope:
>>>>>
>>>>> Sorry, that is of course, if there is no V4L1 compat layer still in
>>>>> place.
>>>>>
>>>>> BTW, qx5view uses a private ioctl() to change the lights on a QX5 and
>>>>> not the V4L2 control.
>>>>
>>>> The better would be to port qx5view to use libv4l and implement the new
>>>> illuminator ctrl on the driver and on the userspase app. Do you have
>>>> hardware for testing this?
>>>
>>> No.  I did check Amazon.com and eBay and saw a QX5 for about US$75 after
>>> shipping costs:
>>>
>>> http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&item=380262406989&rvr_id=139147359954&crlp=1_263602_263622&UA=L*F%3F&GUID=0b3b537412b0a0e203e63006ff9becb0&itemid=380262406989&ff4=263602_263622
>>>
>>> I'm not sure if I want to buy one at that price, since I already have a
>>> QX3.
>>>
>>> Regards,
>>> Andy
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>Hello Andy, Mauro
>>
>>I own a USB Microscope which looks quite the same as the one in your 
>>link, but I don't know if it is similar to the QX3 or QX5.
>>It is called "Traveler USB-Mikroskop" and model number is "SU 1071".
>>One of this two:
>>http://www.traveler-service.de/cms/index.php?id=traveler-optische-geraete-de
>>
>>USB ID: 1871:01b0 Aveo Technology Corp.
>>
>>It is not working in Ubuntu 10.04, kernel AMD64 2.6.32-24-generic.
>>
>>If it is a QX5, I can help testing.
>>
>>Regards,
>>Thomas
>>
>>