From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Dan Carpenter <error27@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
H Hartley Sweeten <hsweeten@visionengravers.com>,
linux-mtd@lists.infradead.org,
Ben Hutchings <bhutchings@solarflare.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [patch] mtd: sanity check input
Date: Mon, 13 Sep 2010 08:53:43 +0000 [thread overview]
Message-ID: <1284368023.27765.179.camel@localhost> (raw)
In-Reply-To: <20100908193956.GB3463@bicker>
On Wed, 2010-09-08 at 21:39 +0200, Dan Carpenter wrote:
> If "ur_idx" is wrong we could go past the end of the array. The
> "ur_idx" comes from root so it's not a huge deal, but adding a sanity
> check makes the code more robust.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
> index a825002..9c00549 100644
> --- a/drivers/mtd/mtdchar.c
> +++ b/drivers/mtd/mtdchar.c
> @@ -513,6 +513,9 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
> if (get_user(ur_idx, &(ur->regionindex)))
> return -EFAULT;
>
> + if (ur_idx >= mtd->numeraseregions)
> + return -EINVAL;
> +
Pushed to l2-mtd-2.6.git with my "Signed-off-by", thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Dan Carpenter <error27@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
H Hartley Sweeten <hsweeten@visionengravers.com>,
linux-mtd@lists.infradead.org,
Ben Hutchings <bhutchings@solarflare.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [patch] mtd: sanity check input
Date: Mon, 13 Sep 2010 11:53:43 +0300 [thread overview]
Message-ID: <1284368023.27765.179.camel@localhost> (raw)
In-Reply-To: <20100908193956.GB3463@bicker>
On Wed, 2010-09-08 at 21:39 +0200, Dan Carpenter wrote:
> If "ur_idx" is wrong we could go past the end of the array. The
> "ur_idx" comes from root so it's not a huge deal, but adding a sanity
> check makes the code more robust.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
> index a825002..9c00549 100644
> --- a/drivers/mtd/mtdchar.c
> +++ b/drivers/mtd/mtdchar.c
> @@ -513,6 +513,9 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
> if (get_user(ur_idx, &(ur->regionindex)))
> return -EFAULT;
>
> + if (ur_idx >= mtd->numeraseregions)
> + return -EINVAL;
> +
Pushed to l2-mtd-2.6.git with my "Signed-off-by", thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Dan Carpenter <error27@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Ben Hutchings <bhutchings@solarflare.com>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] mtd: sanity check input
Date: Mon, 13 Sep 2010 11:53:43 +0300 [thread overview]
Message-ID: <1284368023.27765.179.camel@localhost> (raw)
In-Reply-To: <20100908193956.GB3463@bicker>
On Wed, 2010-09-08 at 21:39 +0200, Dan Carpenter wrote:
> If "ur_idx" is wrong we could go past the end of the array. The
> "ur_idx" comes from root so it's not a huge deal, but adding a sanity
> check makes the code more robust.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
> index a825002..9c00549 100644
> --- a/drivers/mtd/mtdchar.c
> +++ b/drivers/mtd/mtdchar.c
> @@ -513,6 +513,9 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
> if (get_user(ur_idx, &(ur->regionindex)))
> return -EFAULT;
>
> + if (ur_idx >= mtd->numeraseregions)
> + return -EINVAL;
> +
Pushed to l2-mtd-2.6.git with my "Signed-off-by", thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-09-13 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 19:39 [patch] mtd: sanity check input Dan Carpenter
2010-09-08 19:39 ` Dan Carpenter
2010-09-08 19:39 ` Dan Carpenter
2010-09-13 8:53 ` Artem Bityutskiy [this message]
2010-09-13 8:53 ` Artem Bityutskiy
2010-09-13 8:53 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284368023.27765.179.camel@localhost \
--to=artem.bityutskiy@nokia.com \
--cc=bhutchings@solarflare.com \
--cc=dwmw2@infradead.org \
--cc=error27@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.