All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [virtual-sta 3/3] mac80211:  Allow multiple STA on same BSS.
Date: Tue, 14 Sep 2010 14:57:02 +0200	[thread overview]
Message-ID: <1284469022.3704.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1284156298-15863-3-git-send-email-greearb@candelatech.com>

On Fri, 2010-09-10 at 15:04 -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> When adding an STA, the old code checked if there was already
> an STA with the same BSS.  Instead, check to see if there is
> exactly the same STA in order to allow multiple STA to be
> associated with the same AP.


You want this instead:

---
 net/mac80211/sta_info.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- wireless-testing.orig/net/mac80211/sta_info.c	2010-09-14 14:53:10.000000000 +0200
+++ wireless-testing/net/mac80211/sta_info.c	2010-09-14 14:55:44.000000000 +0200
@@ -125,7 +125,7 @@ struct sta_info *sta_info_get_bss(struct
 				    lockdep_is_held(&local->sta_mtx));
 	while (sta) {
 		if ((sta->sdata == sdata ||
-		     sta->sdata->bss == sdata->bss) &&
+		     (sta->sdata->bss && sta->sdata->bss == sdata->bss)) &&
 		    memcmp(sta->sta.addr, addr, ETH_ALEN) == 0)
 			break;
 		sta = rcu_dereference_check(sta->hnext,


johannes


  parent reply	other threads:[~2010-09-14 12:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10 22:04 [virtual-sta 1/3] mac80211: Add more general interface iterator greearb
2010-09-10 22:04 ` [virtual-sta 2/3] ath9k: Calculate bssid-mask and rxfilter for 2+ STAs greearb
2010-09-10 22:04 ` [virtual-sta 3/3] mac80211: Allow multiple STA on same BSS greearb
2010-09-10 22:44   ` Felix Fietkau
2010-09-10 22:49     ` Ben Greear
2010-09-10 22:54       ` Felix Fietkau
2010-09-14 12:57   ` Johannes Berg [this message]
2010-09-14 15:45     ` Ben Greear
2010-09-14 12:59 ` [virtual-sta 1/3] mac80211: Add more general interface iterator Johannes Berg
2010-09-14 14:47   ` Ben Greear
2010-09-14 14:53     ` Johannes Berg
2010-09-14 15:26       ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284469022.3704.1.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.