From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [virtual-sta 1/3] mac80211: Add more general interface iterator.
Date: Tue, 14 Sep 2010 16:53:00 +0200 [thread overview]
Message-ID: <1284475980.3704.13.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4C8F8B0D.8050902@candelatech.com>
On Tue, 2010-09-14 at 07:47 -0700, Ben Greear wrote:
> I'll see if I can get ath9k to use the normal iterator. I didn't need my
> own iterator, because I could just pass in NULL for iterator and pass
> active_only as false.
active_only as false still doesn't seem right. Why would you care about
it before an interface is up?
> I think you should consider returning the count for the number of times the
> iterator was called because it's simple code, and it would save the same logic
> in each driver's iterator methods (or at least, ath9k).
Yeah, that seems like a good change, but I think we should probably get
to the bottom of it first (the sdata->bss change on the other hand seems
fine as is)
johannes
next prev parent reply other threads:[~2010-09-14 14:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 22:04 [virtual-sta 1/3] mac80211: Add more general interface iterator greearb
2010-09-10 22:04 ` [virtual-sta 2/3] ath9k: Calculate bssid-mask and rxfilter for 2+ STAs greearb
2010-09-10 22:04 ` [virtual-sta 3/3] mac80211: Allow multiple STA on same BSS greearb
2010-09-10 22:44 ` Felix Fietkau
2010-09-10 22:49 ` Ben Greear
2010-09-10 22:54 ` Felix Fietkau
2010-09-14 12:57 ` Johannes Berg
2010-09-14 15:45 ` Ben Greear
2010-09-14 12:59 ` [virtual-sta 1/3] mac80211: Add more general interface iterator Johannes Berg
2010-09-14 14:47 ` Ben Greear
2010-09-14 14:53 ` Johannes Berg [this message]
2010-09-14 15:26 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284475980.3704.13.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.