From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
alsa-devel@alsa-project.org, linux-sh@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 3/5] ASoC: lowercase wm8978 codec name to match its only user and other codecs
Date: Mon, 20 Sep 2010 09:12:52 +0100 [thread overview]
Message-ID: <1284970372.3403.15.camel@odin> (raw)
In-Reply-To: <20100917125319.GF4322@rakim.wolfsonmicro.main>
On Fri, 2010-09-17 at 13:53 +0100, Mark Brown wrote:
> On Fri, Sep 17, 2010 at 12:30:05PM +0200, Guennadi Liakhovetski wrote:
> > All ASoC codecs are called in lower case, adjust wm8978 to match them and also
> > to match its so far only user - the sh7722 migor board.
>
> > .driver = {
> > - .name = "WM8978-codec",
> > + .name = "wm8978-codec",
>
> Better yet would be to rename this to wm8978 (and adjust the board).
Fwiw, the reason for the "-codec" suffix was to distinguish codec
devices from their other multi-function IC siblings. It also makes sense
here to use convention with the device naming too (even if the device is
single purpose).
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
WARNING: multiple messages have this Message-ID (diff)
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
alsa-devel@alsa-project.org, linux-sh@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 3/5] ASoC: lowercase wm8978 codec name to
Date: Mon, 20 Sep 2010 08:12:52 +0000 [thread overview]
Message-ID: <1284970372.3403.15.camel@odin> (raw)
In-Reply-To: <20100917125319.GF4322@rakim.wolfsonmicro.main>
On Fri, 2010-09-17 at 13:53 +0100, Mark Brown wrote:
> On Fri, Sep 17, 2010 at 12:30:05PM +0200, Guennadi Liakhovetski wrote:
> > All ASoC codecs are called in lower case, adjust wm8978 to match them and also
> > to match its so far only user - the sh7722 migor board.
>
> > .driver = {
> > - .name = "WM8978-codec",
> > + .name = "wm8978-codec",
>
> Better yet would be to rename this to wm8978 (and adjust the board).
Fwiw, the reason for the "-codec" suffix was to distinguish codec
devices from their other multi-function IC siblings. It also makes sense
here to use convention with the device naming too (even if the device is
single purpose).
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-09-20 8:12 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 10:29 [PATCH 0/5] fix SIU and Migo-R sound for 2.6.37 Guennadi Liakhovetski
2010-09-17 10:29 ` Guennadi Liakhovetski
2010-09-17 10:29 ` [PATCH 1/5] ASoC: fix compile breakage of the sh/siu driver Guennadi Liakhovetski
2010-09-17 10:29 ` Guennadi Liakhovetski
2010-09-19 15:04 ` Mark Brown
2010-09-19 15:04 ` Mark Brown
2010-09-17 10:30 ` [PATCH 2/5] sh: fix an SIU device name mismatch Guennadi Liakhovetski
2010-09-17 10:30 ` Guennadi Liakhovetski
2010-09-19 15:04 ` Mark Brown
2010-09-19 15:04 ` Mark Brown
2010-09-17 10:30 ` [PATCH 3/5] ASoC: lowercase wm8978 codec name to match its only user and other codecs Guennadi Liakhovetski
2010-09-17 10:30 ` [PATCH 3/5] ASoC: lowercase wm8978 codec name to match its only user Guennadi Liakhovetski
2010-09-17 12:53 ` [PATCH 3/5] ASoC: lowercase wm8978 codec name to match its only user and other codecs Mark Brown
2010-09-17 12:53 ` [PATCH 3/5] ASoC: lowercase wm8978 codec name to match its Mark Brown
2010-09-19 15:59 ` [PATCH 3/5] ASoC: lowercase wm8978 codec name to match its only user and other codecs Guennadi Liakhovetski
2010-09-19 15:59 ` [PATCH 3/5] ASoC: lowercase wm8978 codec name to match its only Guennadi Liakhovetski
2010-09-19 19:45 ` [PATCH 3/5] ASoC: lowercase wm8978 codec name to match its only user and other codecs Mark Brown
2010-09-19 19:45 ` [PATCH 3/5] ASoC: lowercase wm8978 codec name to match its Mark Brown
2010-09-20 8:12 ` Liam Girdwood [this message]
2010-09-20 8:12 ` [alsa-devel] [PATCH 3/5] ASoC: lowercase wm8978 codec name to Liam Girdwood
2010-09-20 9:29 ` [alsa-devel] [PATCH 3/5] ASoC: lowercase wm8978 codec name to match its only user and other codecs Mark Brown
2010-09-20 9:29 ` [alsa-devel] [PATCH 3/5] ASoC: lowercase wm8978 codec name to Mark Brown
2010-09-17 10:30 ` [PATCH 4/5] ASoC: fix clkdev API usage in sh/migor.c Guennadi Liakhovetski
2010-09-17 10:30 ` Guennadi Liakhovetski
2010-09-19 15:05 ` Mark Brown
2010-09-19 15:05 ` Mark Brown
2010-09-17 10:30 ` [PATCH 5/5] ASoC: fix SIU driver breakage, occurred during the multi-component transition Guennadi Liakhovetski
2010-09-17 10:30 ` [PATCH 5/5] ASoC: fix SIU driver breakage, occurred during the Guennadi Liakhovetski
2010-09-19 15:05 ` [PATCH 5/5] ASoC: fix SIU driver breakage, occurred during the multi-component transition Mark Brown
2010-09-19 15:05 ` [PATCH 5/5] ASoC: fix SIU driver breakage, occurred during the Mark Brown
2010-09-17 12:19 ` [PATCH 0/5] fix SIU and Migo-R sound for 2.6.37 Mark Brown
2010-09-17 12:19 ` Mark Brown
2010-09-17 12:35 ` Guennadi Liakhovetski
2010-09-17 12:35 ` Guennadi Liakhovetski
2010-09-17 12:59 ` Mark Brown
2010-09-17 12:59 ` Mark Brown
2010-09-17 13:13 ` Guennadi Liakhovetski
2010-09-17 13:13 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284970372.3403.15.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.