From: Johannes Berg <johannes@sipsolutions.net>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211: clear txflags for filtered/retried frames
Date: Mon, 20 Sep 2010 12:23:50 +0200 [thread overview]
Message-ID: <1284978231.3688.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201009182133.50104.chunkeey@googlemail.com>
On Sat, 2010-09-18 at 21:33 +0200, Christian Lamparter wrote:
> info->flags |= IEEE80211_TX_INTFL_NEED_TXPROCESSING |
> IEEE80211_TX_INTFL_RETRANSMISSION;
> + info->flags &= ~(IEEE80211_TX_CTL_RATE_CTRL_PROBE |
> + IEEE80211_TX_CTL_PSPOLL_RESPONSE |
> + IEEE80211_TX_CTL_FIRST_FRAGMENT |
> + IEEE80211_TX_CTL_CLEAR_PS_FILT |
> + IEEE80211_TX_CTL_MORE_FRAMES |
> + IEEE80211_TX_CTL_AMPDU |
> + IEEE80211_TX_STAT_AMPDU_NO_BACK |
> + IEEE80211_TX_STAT_TX_FILTERED |
> + IEEE80211_TX_STAT_AMPDU);
Theo nly thing I wonder is if we should introduce some #define for the
temporary flags here and put it into mac80211.h so we'll be less likely
to forget updating it when adding new flags?
johannes
next prev parent reply other threads:[~2010-09-20 10:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-18 19:33 [RFC] mac80211: clear txflags for filtered/retried frames Christian Lamparter
2010-09-20 10:23 ` Johannes Berg [this message]
2010-09-20 22:22 ` [PATCH] mac80211: clear txflags for ps-filtered frames Christian Lamparter
2010-09-21 6:33 ` Johannes Berg
2010-09-21 19:36 ` [PATCH v2] " Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284978231.3688.2.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.