All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Lamparter <chunkeey@googlemail.com>
To: linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes@sipsolutions.net>
Subject: [RFC] mac80211: clear txflags for filtered/retried frames
Date: Sat, 18 Sep 2010 21:33:49 +0200	[thread overview]
Message-ID: <201009182133.50104.chunkeey@googlemail.com> (raw)

This patch fixes stale mac80211_tx_control_flags for
filtered / retried frames.

Because ieee80211_handle_filtered_frame injects the skbs
back into the tx path, they have to be stripped of old tx
flags which might confuse the stack or driver.
---
diff --git a/net/mac80211/status.c b/net/mac80211/status.c
index 571b32b..17d98a2 100644
--- a/net/mac80211/status.c
+++ b/net/mac80211/status.c
@@ -58,6 +58,15 @@ static void ieee80211_handle_filtered_frame(struct ieee80211_local *local,
 	info->control.vif = &sta->sdata->vif;
 	info->flags |= IEEE80211_TX_INTFL_NEED_TXPROCESSING |
 		       IEEE80211_TX_INTFL_RETRANSMISSION;
+	info->flags &= ~(IEEE80211_TX_CTL_RATE_CTRL_PROBE |
+			 IEEE80211_TX_CTL_PSPOLL_RESPONSE |
+			 IEEE80211_TX_CTL_FIRST_FRAGMENT |
+			 IEEE80211_TX_CTL_CLEAR_PS_FILT |
+			 IEEE80211_TX_CTL_MORE_FRAMES |
+			 IEEE80211_TX_CTL_AMPDU |
+			 IEEE80211_TX_STAT_AMPDU_NO_BACK |
+			 IEEE80211_TX_STAT_TX_FILTERED |
+			 IEEE80211_TX_STAT_AMPDU);
 
 	sta->tx_filtered_count++;
 

             reply	other threads:[~2010-09-18 19:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-18 19:33 Christian Lamparter [this message]
2010-09-20 10:23 ` [RFC] mac80211: clear txflags for filtered/retried frames Johannes Berg
2010-09-20 22:22   ` [PATCH] mac80211: clear txflags for ps-filtered frames Christian Lamparter
2010-09-21  6:33     ` Johannes Berg
2010-09-21 19:36       ` [PATCH v2] " Christian Lamparter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201009182133.50104.chunkeey@googlemail.com \
    --to=chunkeey@googlemail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.