* [PATCH] utils.bbclass: fix is_machine_specific
@ 2010-09-20 22:58 Eric Bénard
2010-09-21 2:51 ` Chris Larson
2010-09-21 3:55 ` Khem Raj
0 siblings, 2 replies; 3+ messages in thread
From: Eric Bénard @ 2010-09-20 22:58 UTC (permalink / raw)
To: openembedded-devel
* base.bbclass can set a package's PACKAGE_ARCH to MACHINE_ARCH if
it finds file:// in the SRC_URI and the corresponding file is machine
specific (recipes/foo/foo-1.0/<some machine>/)
* but is_machine_specific actually fails to detect these files as
urldata.path is used instead of urldata.localpath thus preventing the
comparison of the file's path with machinepaths
* tested with bitbake HEAD & 1.8.18, with OE's tree alone and OE's tree
plus an overlay.
Signed-off-by: Eric Bénard <eric@eukrea.com>
---
classes/utils.bbclass | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/classes/utils.bbclass b/classes/utils.bbclass
index 0a7a045..1c636be 100644
--- a/classes/utils.bbclass
+++ b/classes/utils.bbclass
@@ -54,7 +54,7 @@ def is_machine_specific(d):
urldatadict = bb.fetch.init(d.getVar("SRC_URI", True).split(), d, True)
for urldata in (urldata for urldata in urldatadict.itervalues()
if urldata.type == "file"):
- if any(urldata.path.startswith(mp + "/") for mp in machinepaths):
+ if any(urldata.localpath.startswith(mp + "/") for mp in machinepaths):
return True
def subprocess_setup():
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] utils.bbclass: fix is_machine_specific
2010-09-20 22:58 [PATCH] utils.bbclass: fix is_machine_specific Eric Bénard
@ 2010-09-21 2:51 ` Chris Larson
2010-09-21 3:55 ` Khem Raj
1 sibling, 0 replies; 3+ messages in thread
From: Chris Larson @ 2010-09-21 2:51 UTC (permalink / raw)
To: openembedded-devel
On Mon, Sep 20, 2010 at 3:58 PM, Eric Bénard <eric@eukrea.com> wrote:
> * base.bbclass can set a package's PACKAGE_ARCH to MACHINE_ARCH if
> it finds file:// in the SRC_URI and the corresponding file is machine
> specific (recipes/foo/foo-1.0/<some machine>/)
> * but is_machine_specific actually fails to detect these files as
> urldata.path is used instead of urldata.localpath thus preventing the
> comparison of the file's path with machinepaths
> * tested with bitbake HEAD & 1.8.18, with OE's tree alone and OE's tree
> plus an overlay.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
>
Acked-by: Chris Larson <clarson@kergoth.com>
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] utils.bbclass: fix is_machine_specific
2010-09-20 22:58 [PATCH] utils.bbclass: fix is_machine_specific Eric Bénard
2010-09-21 2:51 ` Chris Larson
@ 2010-09-21 3:55 ` Khem Raj
1 sibling, 0 replies; 3+ messages in thread
From: Khem Raj @ 2010-09-21 3:55 UTC (permalink / raw)
To: openembedded-devel
On Mon, Sep 20, 2010 at 3:58 PM, Eric Bénard <eric@eukrea.com> wrote:
> * base.bbclass can set a package's PACKAGE_ARCH to MACHINE_ARCH if
> it finds file:// in the SRC_URI and the corresponding file is machine
> specific (recipes/foo/foo-1.0/<some machine>/)
> * but is_machine_specific actually fails to detect these files as
> urldata.path is used instead of urldata.localpath thus preventing the
> comparison of the file's path with machinepaths
> * tested with bitbake HEAD & 1.8.18, with OE's tree alone and OE's tree
> plus an overlay.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
Acked-by: Khem Raj <raj.khem@gmail.com>
> ---
> classes/utils.bbclass | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/classes/utils.bbclass b/classes/utils.bbclass
> index 0a7a045..1c636be 100644
> --- a/classes/utils.bbclass
> +++ b/classes/utils.bbclass
> @@ -54,7 +54,7 @@ def is_machine_specific(d):
> urldatadict = bb.fetch.init(d.getVar("SRC_URI", True).split(), d, True)
> for urldata in (urldata for urldata in urldatadict.itervalues()
> if urldata.type == "file"):
> - if any(urldata.path.startswith(mp + "/") for mp in machinepaths):
> + if any(urldata.localpath.startswith(mp + "/") for mp in machinepaths):
> return True
>
> def subprocess_setup():
> --
> 1.6.3.3
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
--
-Khem
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-21 3:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-20 22:58 [PATCH] utils.bbclass: fix is_machine_specific Eric Bénard
2010-09-21 2:51 ` Chris Larson
2010-09-21 3:55 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.