* [PATCH] ASoC: Select DMA driver for Samsung DAIs
@ 2010-09-20 19:38 Mark Brown
2010-09-21 0:38 ` Jassi Brar
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Mark Brown @ 2010-09-20 19:38 UTC (permalink / raw)
To: Jassi Brar, Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown
Kconfig got smart enough to do dependencies through selects so let's make
use of that.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/s3c24xx/Kconfig | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sound/soc/s3c24xx/Kconfig b/sound/soc/s3c24xx/Kconfig
index 7d8235d..1142d3e 100644
--- a/sound/soc/s3c24xx/Kconfig
+++ b/sound/soc/s3c24xx/Kconfig
@@ -10,6 +10,7 @@ config SND_S3C24XX_SOC
config SND_S3C24XX_SOC_I2S
tristate
select S3C2410_DMA
+ select SND_S3C_SOC_PCM
config SND_S3C_I2SV2_SOC
tristate
@@ -18,16 +19,19 @@ config SND_S3C2412_SOC_I2S
tristate
select SND_S3C_I2SV2_SOC
select S3C2410_DMA
+ select SND_S3C_SOC_PCM
config SND_S3C64XX_SOC_I2S
tristate
select SND_S3C_I2SV2_SOC
select S3C64XX_DMA
+ select SND_S3C_SOC_PCM
config SND_S3C64XX_SOC_I2S_V4
tristate
select SND_S3C_I2SV2_SOC
select S3C64XX_DMA
+ select SND_S3C_SOC_PCM
config SND_S3C_SOC_PCM
tristate
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ASoC: Select DMA driver for Samsung DAIs
2010-09-20 19:38 [PATCH] ASoC: Select DMA driver for Samsung DAIs Mark Brown
@ 2010-09-21 0:38 ` Jassi Brar
2010-09-21 13:22 ` Mark Brown
2010-09-21 13:07 ` Liam Girdwood
2010-09-22 6:10 ` Vasily Khoruzhick
2 siblings, 1 reply; 5+ messages in thread
From: Jassi Brar @ 2010-09-21 0:38 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, patches, Jassi Brar, Liam Girdwood
On Tue, Sep 21, 2010 at 4:38 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> Kconfig got smart enough to do dependencies through selects so let's make
> use of that.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/s3c24xx/Kconfig | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/s3c24xx/Kconfig b/sound/soc/s3c24xx/Kconfig
> index 7d8235d..1142d3e 100644
> --- a/sound/soc/s3c24xx/Kconfig
> +++ b/sound/soc/s3c24xx/Kconfig
> @@ -10,6 +10,7 @@ config SND_S3C24XX_SOC
> config SND_S3C24XX_SOC_I2S
> tristate
> select S3C2410_DMA
> + select SND_S3C_SOC_PCM
>
> config SND_S3C_I2SV2_SOC
> tristate
> @@ -18,16 +19,19 @@ config SND_S3C2412_SOC_I2S
> tristate
> select SND_S3C_I2SV2_SOC
> select S3C2410_DMA
> + select SND_S3C_SOC_PCM
>
> config SND_S3C64XX_SOC_I2S
> tristate
> select SND_S3C_I2SV2_SOC
> select S3C64XX_DMA
> + select SND_S3C_SOC_PCM
>
> config SND_S3C64XX_SOC_I2S_V4
> tristate
> select SND_S3C_I2SV2_SOC
> select S3C64XX_DMA
> + select SND_S3C_SOC_PCM
>
> config SND_S3C_SOC_PCM
> tristate
> --
SND_S3C_SOC_PCM builds s3c-pcm.c, which is the PCM controller's CPU driver.
s3c-dma.c is the DMA driver for Samsung SoCs, which is already built
as the first
thing for Samsung ASoC.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Select DMA driver for Samsung DAIs
2010-09-21 0:38 ` Jassi Brar
@ 2010-09-21 13:22 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2010-09-21 13:22 UTC (permalink / raw)
To: Jassi Brar; +Cc: alsa-devel, patches, Jassi Brar, Liam Girdwood
On Tue, Sep 21, 2010 at 09:38:04AM +0900, Jassi Brar wrote:
> SND_S3C_SOC_PCM builds s3c-pcm.c, which is the PCM controller's CPU driver.
> s3c-dma.c is the DMA driver for Samsung SoCs, which is already built
> as the first
> thing for Samsung ASoC.
Gah, yeah. Wonder what my actual problem was then...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Select DMA driver for Samsung DAIs
2010-09-20 19:38 [PATCH] ASoC: Select DMA driver for Samsung DAIs Mark Brown
2010-09-21 0:38 ` Jassi Brar
@ 2010-09-21 13:07 ` Liam Girdwood
2010-09-22 6:10 ` Vasily Khoruzhick
2 siblings, 0 replies; 5+ messages in thread
From: Liam Girdwood @ 2010-09-21 13:07 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, patches, Jassi Brar
On Mon, 2010-09-20 at 20:38 +0100, Mark Brown wrote:
> Kconfig got smart enough to do dependencies through selects so let's make
> use of that.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/s3c24xx/Kconfig | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/s3c24xx/Kconfig b/sound/soc/s3c24xx/Kconfig
> index 7d8235d..1142d3e 100644
> --- a/sound/soc/s3c24xx/Kconfig
> +++ b/sound/soc/s3c24xx/Kconfig
> @@ -10,6 +10,7 @@ config SND_S3C24XX_SOC
> config SND_S3C24XX_SOC_I2S
> tristate
> select S3C2410_DMA
> + select SND_S3C_SOC_PCM
>
> config SND_S3C_I2SV2_SOC
> tristate
> @@ -18,16 +19,19 @@ config SND_S3C2412_SOC_I2S
> tristate
> select SND_S3C_I2SV2_SOC
> select S3C2410_DMA
> + select SND_S3C_SOC_PCM
>
> config SND_S3C64XX_SOC_I2S
> tristate
> select SND_S3C_I2SV2_SOC
> select S3C64XX_DMA
> + select SND_S3C_SOC_PCM
>
> config SND_S3C64XX_SOC_I2S_V4
> tristate
> select SND_S3C_I2SV2_SOC
> select S3C64XX_DMA
> + select SND_S3C_SOC_PCM
>
> config SND_S3C_SOC_PCM
> tristate
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Select DMA driver for Samsung DAIs
2010-09-20 19:38 [PATCH] ASoC: Select DMA driver for Samsung DAIs Mark Brown
2010-09-21 0:38 ` Jassi Brar
2010-09-21 13:07 ` Liam Girdwood
@ 2010-09-22 6:10 ` Vasily Khoruzhick
2 siblings, 0 replies; 5+ messages in thread
From: Vasily Khoruzhick @ 2010-09-22 6:10 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown, patches, Jassi Brar, Liam Girdwood
On 20 of September 2010 22:38:28 Mark Brown wrote:
> Kconfig got smart enough to do dependencies through selects so let's make
> use of that.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/s3c24xx/Kconfig | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/s3c24xx/Kconfig b/sound/soc/s3c24xx/Kconfig
> index 7d8235d..1142d3e 100644
> --- a/sound/soc/s3c24xx/Kconfig
> +++ b/sound/soc/s3c24xx/Kconfig
> @@ -10,6 +10,7 @@ config SND_S3C24XX_SOC
> config SND_S3C24XX_SOC_I2S
> tristate
> select S3C2410_DMA
> + select SND_S3C_SOC_PCM
SND_S3C_SOC_PCM is not necessary for SND_S3C24XX_SOC, actually it works fine
without it on my rx1950 (s3c2442-based)
> config SND_S3C_I2SV2_SOC
> tristate
> @@ -18,16 +19,19 @@ config SND_S3C2412_SOC_I2S
> tristate
> select SND_S3C_I2SV2_SOC
> select S3C2410_DMA
> + select SND_S3C_SOC_PCM
>
> config SND_S3C64XX_SOC_I2S
> tristate
> select SND_S3C_I2SV2_SOC
> select S3C64XX_DMA
> + select SND_S3C_SOC_PCM
>
> config SND_S3C64XX_SOC_I2S_V4
> tristate
> select SND_S3C_I2SV2_SOC
> select S3C64XX_DMA
> + select SND_S3C_SOC_PCM
>
> config SND_S3C_SOC_PCM
> tristate
Regards
Vasily
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-09-22 6:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-20 19:38 [PATCH] ASoC: Select DMA driver for Samsung DAIs Mark Brown
2010-09-21 0:38 ` Jassi Brar
2010-09-21 13:22 ` Mark Brown
2010-09-21 13:07 ` Liam Girdwood
2010-09-22 6:10 ` Vasily Khoruzhick
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.