* [PATCH] ASoC: Remove extra rtd->dev.init_name assignment in soc_probe_dai_link
@ 2010-09-21 12:36 Jarkko Nikula
2010-09-21 13:07 ` Liam Girdwood
2010-09-21 17:43 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Jarkko Nikula @ 2010-09-21 12:36 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown, Liam Girdwood
rtd->dev.init_name is set twice in soc_probe_dai_link. I removed the first
assignement from dai_link->stream_name since then there won't be sysfs name
changes and usually dai_link->name seems to fit anyway better for a sysfs
directory name.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
---
sound/soc/soc-core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 6001b7f..c8d1596 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1451,7 +1451,6 @@ static int soc_probe_dai_link(struct snd_soc_card *card, int num)
snd_soc_dapm_sync(codec);
/* register the rtd device */
- rtd->dev.init_name = rtd->dai_link->stream_name;
rtd->dev.release = rtd_release;
rtd->dev.init_name = dai_link->name;
ret = device_register(&rtd->dev);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Remove extra rtd->dev.init_name assignment in soc_probe_dai_link
2010-09-21 12:36 [PATCH] ASoC: Remove extra rtd->dev.init_name assignment in soc_probe_dai_link Jarkko Nikula
@ 2010-09-21 13:07 ` Liam Girdwood
2010-09-21 17:43 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-09-21 13:07 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: alsa-devel, Mark Brown
On Tue, 2010-09-21 at 15:36 +0300, Jarkko Nikula wrote:
> rtd->dev.init_name is set twice in soc_probe_dai_link. I removed the first
> assignement from dai_link->stream_name since then there won't be sysfs name
> changes and usually dai_link->name seems to fit anyway better for a sysfs
> directory name.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> ---
> sound/soc/soc-core.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 6001b7f..c8d1596 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1451,7 +1451,6 @@ static int soc_probe_dai_link(struct snd_soc_card *card, int num)
> snd_soc_dapm_sync(codec);
>
> /* register the rtd device */
> - rtd->dev.init_name = rtd->dai_link->stream_name;
> rtd->dev.release = rtd_release;
> rtd->dev.init_name = dai_link->name;
> ret = device_register(&rtd->dev);
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Remove extra rtd->dev.init_name assignment in soc_probe_dai_link
2010-09-21 12:36 [PATCH] ASoC: Remove extra rtd->dev.init_name assignment in soc_probe_dai_link Jarkko Nikula
2010-09-21 13:07 ` Liam Girdwood
@ 2010-09-21 17:43 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-09-21 17:43 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: alsa-devel, Liam Girdwood
On Tue, Sep 21, 2010 at 03:36:49PM +0300, Jarkko Nikula wrote:
> rtd->dev.init_name is set twice in soc_probe_dai_link. I removed the first
> assignement from dai_link->stream_name since then there won't be sysfs name
> changes and usually dai_link->name seems to fit anyway better for a sysfs
> directory name.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-21 17:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-21 12:36 [PATCH] ASoC: Remove extra rtd->dev.init_name assignment in soc_probe_dai_link Jarkko Nikula
2010-09-21 13:07 ` Liam Girdwood
2010-09-21 17:43 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.