* [PATCH] ASoC: Report error codes for card DAI instantiation failures
@ 2010-09-21 16:24 Mark Brown
2010-09-22 8:54 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2010-09-21 16:24 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown
Also clean up the error print a bit.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/soc-core.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 7c64e03..5c58651 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1568,7 +1568,8 @@ static void snd_soc_instantiate_card(struct snd_soc_card *card)
for (i = 0; i < card->num_links; i++) {
ret = soc_probe_dai_link(card, i);
if (ret < 0) {
- printk(KERN_ERR "asoc: failed to instanciate card %s\n", card->name);
+ pr_err("asoc: failed to instantiate card %s: %d\n",
+ card->name, ret);
goto probe_dai_err;
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: Report error codes for card DAI instantiation failures
2010-09-21 16:24 [PATCH] ASoC: Report error codes for card DAI instantiation failures Mark Brown
@ 2010-09-22 8:54 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2010-09-22 8:54 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, patches
On Tue, 2010-09-21 at 17:24 +0100, Mark Brown wrote:
> Also clean up the error print a bit.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/soc-core.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 7c64e03..5c58651 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1568,7 +1568,8 @@ static void snd_soc_instantiate_card(struct snd_soc_card *card)
> for (i = 0; i < card->num_links; i++) {
> ret = soc_probe_dai_link(card, i);
> if (ret < 0) {
> - printk(KERN_ERR "asoc: failed to instanciate card %s\n", card->name);
> + pr_err("asoc: failed to instantiate card %s: %d\n",
> + card->name, ret);
> goto probe_dai_err;
> }
> }
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-22 8:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-21 16:24 [PATCH] ASoC: Report error codes for card DAI instantiation failures Mark Brown
2010-09-22 8:54 ` Liam Girdwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.