* [PATCH] ASoC: WM8985: Remove unneeded declaration.
@ 2010-09-24 12:02 Dimitris Papastamos
2010-09-24 15:31 ` Liam Girdwood
2010-09-24 16:01 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Dimitris Papastamos @ 2010-09-24 12:02 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, patches
We are not using the private data in this function, so get rid of it.
Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8985.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/wm8985.c b/sound/soc/codecs/wm8985.c
index 247585a..b94af96 100644
--- a/sound/soc/codecs/wm8985.c
+++ b/sound/soc/codecs/wm8985.c
@@ -557,12 +557,10 @@ static int wm8985_dac_mute(struct snd_soc_dai *dai, int mute)
static int wm8985_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
{
- struct wm8985_priv *wm8985;
struct snd_soc_codec *codec;
u16 format, master, bcp, lrp;
codec = dai->codec;
- wm8985 = snd_soc_codec_get_drvdata(codec);
switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
case SND_SOC_DAIFMT_I2S:
--
1.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: WM8985: Remove unneeded declaration.
2010-09-24 12:02 [PATCH] ASoC: WM8985: Remove unneeded declaration Dimitris Papastamos
@ 2010-09-24 15:31 ` Liam Girdwood
2010-09-24 16:01 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-09-24 15:31 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, Mark Brown, patches
On Fri, 2010-09-24 at 13:02 +0100, Dimitris Papastamos wrote:
> We are not using the private data in this function, so get rid of it.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8985.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8985.c b/sound/soc/codecs/wm8985.c
> index 247585a..b94af96 100644
> --- a/sound/soc/codecs/wm8985.c
> +++ b/sound/soc/codecs/wm8985.c
> @@ -557,12 +557,10 @@ static int wm8985_dac_mute(struct snd_soc_dai *dai, int mute)
>
> static int wm8985_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
> {
> - struct wm8985_priv *wm8985;
> struct snd_soc_codec *codec;
> u16 format, master, bcp, lrp;
>
> codec = dai->codec;
> - wm8985 = snd_soc_codec_get_drvdata(codec);
>
> switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> case SND_SOC_DAIFMT_I2S:
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: WM8985: Remove unneeded declaration.
2010-09-24 12:02 [PATCH] ASoC: WM8985: Remove unneeded declaration Dimitris Papastamos
2010-09-24 15:31 ` Liam Girdwood
@ 2010-09-24 16:01 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-09-24 16:01 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, patches, Liam Girdwood
On Fri, Sep 24, 2010 at 01:02:07PM +0100, Dimitris Papastamos wrote:
> We are not using the private data in this function, so get rid of it.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-24 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-24 12:02 [PATCH] ASoC: WM8985: Remove unneeded declaration Dimitris Papastamos
2010-09-24 15:31 ` Liam Girdwood
2010-09-24 16:01 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.