From: Joe Perches <joe@perches.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Julia Lawall" <julia@diku.dk>,
git@vger.kernel.org, "Vasiliy Kulikov" <segooon@gmail.com>,
"Matt Mooney" <mfmooney@gmail.com>,
kernel-janitors@vger.kernel.org,
"Dan Carpenter" <error27@gmail.com>
Subject: Re: [PATCH V3] git-send-email.perl: Add --to-cmd
Date: Fri, 24 Sep 2010 16:06:34 +0000 [thread overview]
Message-ID: <1285344394.11616.23.camel@Joe-Laptop> (raw)
In-Reply-To: <m3lj6rgnub.fsf@localhost.localdomain>
On Fri, 2010-09-24 at 08:32 -0700, Jakub Narebski wrote:
> Joe Perches <joe@perches.com> writes:
> > +# Execute a command (ie: $to_cmd) to get a list of email addresses
> > +# and return a results array
> > +sub recipients_cmd(@) {
> Do not use subroutine prototypes: they do not do what you think they
> do. In this case using prototype is unnecessary and can be dangerous.
It can be removed. I was following the form of the
other returned array in the code.
sub unique_email_list(@) {
> > + while(<F>) {
> > + my $address = $_;
> > + $address =~ s/^\s*//g;
> > + $address =~ s/\n$//g;
> Hmmm... why does it remove leading, but not trailing whitespace?
Unmodified from the current. I agree it should do both.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Julia Lawall" <julia@diku.dk>,
git@vger.kernel.org, "Vasiliy Kulikov" <segooon@gmail.com>,
"Matt Mooney" <mfmooney@gmail.com>,
kernel-janitors@vger.kernel.org,
"Dan Carpenter" <error27@gmail.com>
Subject: Re: [PATCH V3] git-send-email.perl: Add --to-cmd
Date: Fri, 24 Sep 2010 09:06:34 -0700 [thread overview]
Message-ID: <1285344394.11616.23.camel@Joe-Laptop> (raw)
In-Reply-To: <m3lj6rgnub.fsf@localhost.localdomain>
On Fri, 2010-09-24 at 08:32 -0700, Jakub Narebski wrote:
> Joe Perches <joe@perches.com> writes:
> > +# Execute a command (ie: $to_cmd) to get a list of email addresses
> > +# and return a results array
> > +sub recipients_cmd(@) {
> Do not use subroutine prototypes: they do not do what you think they
> do. In this case using prototype is unnecessary and can be dangerous.
It can be removed. I was following the form of the
other returned array in the code.
sub unique_email_list(@) {
> > + while(<F>) {
> > + my $address = $_;
> > + $address =~ s/^\s*//g;
> > + $address =~ s/\n$//g;
> Hmmm... why does it remove leading, but not trailing whitespace?
Unmodified from the current. I agree it should do both.
next prev parent reply other threads:[~2010-09-24 16:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTinsM5jdU194FR8L3hTvBXk0Tr_oV2E5752NOUpq@mail.gmail.com>
2010-09-23 7:11 ` threaded patch series matt mooney
2010-09-23 7:36 ` Joe Perches
2010-09-23 8:55 ` Julia Lawall
2010-09-23 9:05 ` Joe Perches
2010-09-23 9:05 ` Joe Perches
2010-09-23 9:09 ` Vasiliy Kulikov
2010-09-23 12:00 ` Vasiliy Kulikov
2010-09-23 14:57 ` Joe Perches
2010-09-23 15:58 ` Julia Lawall
2010-09-23 17:17 ` [RFC PATCH] sit-send-email.pl: Add --to-cmd Joe Perches
2010-09-23 17:17 ` Joe Perches
2010-09-23 17:29 ` Ævar Arnfjörð Bjarmason
2010-09-23 17:46 ` Joe Perches
2010-09-23 17:46 ` Joe Perches
2010-09-23 17:50 ` Ævar Arnfjörð Bjarmason
2010-09-23 18:45 ` [PATCH V2] git-send-email.perl: " Joe Perches
2010-09-23 18:45 ` Joe Perches
2010-09-23 19:57 ` matt mooney
2010-09-23 19:57 ` matt mooney
2010-09-23 22:37 ` Junio C Hamano
2010-09-23 22:37 ` Junio C Hamano
2010-09-23 23:16 ` Ævar Arnfjörð Bjarmason
2010-09-24 1:18 ` [PATCH V3] " Joe Perches
2010-09-24 1:18 ` Joe Perches
2010-09-24 15:32 ` Jakub Narebski
2010-09-24 15:32 ` Jakub Narebski
2010-09-24 16:06 ` Joe Perches [this message]
2010-09-24 16:06 ` Joe Perches
2010-09-24 16:47 ` Ævar Arnfjörð Bjarmason
2010-09-24 17:03 ` [PATCH V4] " Joe Perches
2010-09-24 17:03 ` Joe Perches
2010-09-24 1:20 ` [PATCH V2] " Joe Perches
2010-09-24 1:20 ` Joe Perches
2010-09-23 18:01 ` threaded patch series matt mooney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285344394.11616.23.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=avarab@gmail.com \
--cc=error27@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=mfmooney@gmail.com \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.