From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <shijie8@gmail.com>
Cc: akpm@linux-foundation.org, linux-mtd@lists.infradead.org,
David.Woodhouse@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd : add init_size hook for NAND driver
Date: Sun, 26 Sep 2010 15:05:19 +0300 [thread overview]
Message-ID: <1285502719.13050.17.camel@brekeke> (raw)
In-Reply-To: <1285328063-7982-1-git-send-email-shijie8@gmail.com>
On Fri, 2010-09-24 at 19:34 +0800, Huang Shijie wrote:
> Not all the NAND devices have all the information in additional
> id bytes.
>
> So add a hook in the nand_chip{} is a good method to calculate the
> right value of oobsize, erasesize and so on.
>
> Without the hook,you will get the wrong value, and you have to hack
> in the ->scan_bbt() to change the wrong value which make the code
> mess.
>
> Signed-off-by: Huang Shijie <shijie8@gmail.com>
> ---
> drivers/mtd/nand/nand_base.c | 6 ++++--
> include/linux/mtd/nand.h | 5 +++++
> 2 files changed, 9 insertions(+), 2 deletions(-)
Taken to l2-mtd-2.6.git, thanks.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <shijie8@gmail.com>
Cc: David.Woodhouse@intel.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] mtd : add init_size hook for NAND driver
Date: Sun, 26 Sep 2010 15:05:19 +0300 [thread overview]
Message-ID: <1285502719.13050.17.camel@brekeke> (raw)
In-Reply-To: <1285328063-7982-1-git-send-email-shijie8@gmail.com>
On Fri, 2010-09-24 at 19:34 +0800, Huang Shijie wrote:
> Not all the NAND devices have all the information in additional
> id bytes.
>
> So add a hook in the nand_chip{} is a good method to calculate the
> right value of oobsize, erasesize and so on.
>
> Without the hook,you will get the wrong value, and you have to hack
> in the ->scan_bbt() to change the wrong value which make the code
> mess.
>
> Signed-off-by: Huang Shijie <shijie8@gmail.com>
> ---
> drivers/mtd/nand/nand_base.c | 6 ++++--
> include/linux/mtd/nand.h | 5 +++++
> 2 files changed, 9 insertions(+), 2 deletions(-)
Taken to l2-mtd-2.6.git, thanks.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2010-09-26 12:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 11:34 [PATCH] mtd : add init_size hook for NAND driver Huang Shijie
2010-09-24 11:34 ` Huang Shijie
2010-09-26 12:05 ` Artem Bityutskiy [this message]
2010-09-26 12:05 ` Artem Bityutskiy
2010-09-27 3:06 ` Huang Shijie
2010-09-27 3:06 ` Huang Shijie
2010-09-28 6:29 ` Artem Bityutskiy
2010-09-28 6:29 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285502719.13050.17.camel@brekeke \
--to=dedekind1@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.