All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: WM8804: Initial driver
Date: Thu, 30 Sep 2010 20:28:53 +0100	[thread overview]
Message-ID: <1285874933.3101.128.camel@odin> (raw)
In-Reply-To: <1285755296-24497-1-git-send-email-dp@opensource.wolfsonmicro.com>

On Wed, 2010-09-29 at 11:14 +0100, Dimitris Papastamos wrote:
> The WM8804 is a high performance consumer mode
> S/PDIF transceiver with support for 1 received channel and
> 1 transmitted channel.
> 
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
> ---
>  sound/soc/codecs/Kconfig  |    4 +
>  sound/soc/codecs/Makefile |    2 +
>  sound/soc/codecs/wm8804.c |  820 +++++++++++++++++++++++++++++++++++++++++++++
>  sound/soc/codecs/wm8804.h |   61 ++++
>  4 files changed, 887 insertions(+), 0 deletions(-)
>  create mode 100644 sound/soc/codecs/wm8804.c
>  create mode 100644 sound/soc/codecs/wm8804.h
> 

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>

but

> +
> +static struct snd_soc_dai_driver wm8804_dai = {
> +	.name = "wm8804-s/pdif",

There may be per DAI debugfs or sysfs info in the future so it's best to
not use a "/" in a name. Can you do an incremental change.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

  reply	other threads:[~2010-09-30 19:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29 10:14 [PATCH] ASoC: WM8804: Initial driver Dimitris Papastamos
2010-09-30 19:28 ` Liam Girdwood [this message]
2010-09-30 20:34 ` Mark Brown
2010-10-04  8:20 ` Grzegorz Daniluk
2010-10-04  9:40   ` Dimitris Papastamos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285874933.3101.128.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.