All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: WM8804: Initial driver
Date: Thu, 30 Sep 2010 13:34:04 -0700	[thread overview]
Message-ID: <20100930203403.GB4175@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1285755296-24497-1-git-send-email-dp@opensource.wolfsonmicro.com>

On Wed, Sep 29, 2010 at 11:14:56AM +0100, Dimitris Papastamos wrote:

> The WM8804 is a high performance consumer mode
> S/PDIF transceiver with support for 1 received channel and
> 1 transmitted channel.

> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>

Applied, thanks but...

> +static int wm8804_set_pll(struct snd_soc_dai *dai, int pll_id,
> +			  int source, unsigned int freq_in,
> +			  unsigned int freq_out)
> +{
> +	int ret;
> +	struct snd_soc_codec *codec;
> +	struct pll_div pll_div = { 0 };

...please provide an incremental patch which fixes this to not override
all the flow control testing as discussed for your other patch.

  parent reply	other threads:[~2010-09-30 20:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29 10:14 [PATCH] ASoC: WM8804: Initial driver Dimitris Papastamos
2010-09-30 19:28 ` Liam Girdwood
2010-09-30 20:34 ` Mark Brown [this message]
2010-10-04  8:20 ` Grzegorz Daniluk
2010-10-04  9:40   ` Dimitris Papastamos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100930203403.GB4175@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.