From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tomi Valkeinen <tomi.valkeinen@nokia.com>, yinghai@kernel.org
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Felipe Balbi <balbi@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
ext Grazvydas Ignotas <notasas@gmail.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: multiple linux-next OMAP3 build errors
Date: Tue, 05 Oct 2010 09:30:22 +1100 [thread overview]
Message-ID: <1286231422.2463.316.camel@pasglop> (raw)
In-Reply-To: <1286173747.2358.4.camel@tubuntu.research.nokia.com>
On Mon, 2010-10-04 at 09:29 +0300, Tomi Valkeinen wrote:
> > CC drivers/video/omap2/vram.o
> > drivers/video/omap2/vram.c: In function
> 'omap_vram_reserve_sdram_memblock':
> > drivers/video/omap2/vram.c:568: error: implicit declaration of
> > function 'memblock_region_is_memory'
>
> Benjamin, your patch "memblock/arm: Use memblock_region_is_memory()
> for
> omap fb" in linux-next seems to be broken. I believe the called
> function
> should be memblock_is_region_memory, not memblock_region_is_memory?
I suspect either I didn't push my latest version before it got merged or
Yinghai didn't pull the right one, since I'm pretty sure I test built
it, but in any case, you're probably right :-)
I'm not in control of this patch series at the moment however. Ingo and
Yinghai are. Yinghai, care to fix that up ? I'm currently travelling on
holidays and won't be able to do much until later next week.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: benh@kernel.crashing.org (Benjamin Herrenschmidt)
To: linux-arm-kernel@lists.infradead.org
Subject: multiple linux-next OMAP3 build errors
Date: Tue, 05 Oct 2010 09:30:22 +1100 [thread overview]
Message-ID: <1286231422.2463.316.camel@pasglop> (raw)
In-Reply-To: <1286173747.2358.4.camel@tubuntu.research.nokia.com>
On Mon, 2010-10-04 at 09:29 +0300, Tomi Valkeinen wrote:
> > CC drivers/video/omap2/vram.o
> > drivers/video/omap2/vram.c: In function
> 'omap_vram_reserve_sdram_memblock':
> > drivers/video/omap2/vram.c:568: error: implicit declaration of
> > function 'memblock_region_is_memory'
>
> Benjamin, your patch "memblock/arm: Use memblock_region_is_memory()
> for
> omap fb" in linux-next seems to be broken. I believe the called
> function
> should be memblock_is_region_memory, not memblock_region_is_memory?
I suspect either I didn't push my latest version before it got merged or
Yinghai didn't pull the right one, since I'm pretty sure I test built
it, but in any case, you're probably right :-)
I'm not in control of this patch series at the moment however. Ingo and
Yinghai are. Yinghai, care to fix that up ? I'm currently travelling on
holidays and won't be able to do much until later next week.
Cheers,
Ben.
next prev parent reply other threads:[~2010-10-04 22:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 15:57 multiple linux-next OMAP3 build errors Grazvydas Ignotas
2010-10-01 15:57 ` Grazvydas Ignotas
2010-10-01 16:12 ` Anand Gadiyar
2010-10-01 16:12 ` Anand Gadiyar
2010-10-01 16:57 ` Tony Lindgren
2010-10-01 16:57 ` Tony Lindgren
2010-10-04 6:29 ` Tomi Valkeinen
2010-10-04 6:29 ` Tomi Valkeinen
2010-10-04 11:04 ` Gadiyar, Anand
2010-10-04 11:04 ` Gadiyar, Anand
2010-10-04 22:30 ` Benjamin Herrenschmidt [this message]
2010-10-04 22:30 ` Benjamin Herrenschmidt
2010-10-04 22:43 ` Yinghai Lu
2010-10-04 22:43 ` Yinghai Lu
2010-10-06 4:28 ` Yinghai Lu
2010-10-06 4:28 ` Yinghai Lu
2010-10-08 7:18 ` [tip:core/memblock] memblock/arm: Fix memblock_region_is_memory() typo tip-bot for Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286231422.2463.316.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=balbi@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=notasas@gmail.com \
--cc=tomi.valkeinen@nokia.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.