All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: Staticise CS4270 DAI
@ 2010-10-06 23:25 Mark Brown
  2010-10-06 23:25 ` [PATCH 2/2] ASoC: Staticise AD1980 DAI Mark Brown
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Mark Brown @ 2010-10-06 23:25 UTC (permalink / raw)
  To: Liam Girdwood, Timur Tabi; +Cc: alsa-devel, patches, Mark Brown

It's not needed with multi-component.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/cs4270.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c
index 5fd8e0d..6d4bdc6 100644
--- a/sound/soc/codecs/cs4270.c
+++ b/sound/soc/codecs/cs4270.c
@@ -518,7 +518,7 @@ static struct snd_soc_dai_ops cs4270_dai_ops = {
 	.digital_mute	= cs4270_dai_mute,
 };
 
-struct snd_soc_dai_driver cs4270_dai = {
+static struct snd_soc_dai_driver cs4270_dai = {
 	.name = "cs4270-hifi",
 	.playback = {
 		.stream_name = "Playback",
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ASoC: Staticise AD1980 DAI
  2010-10-06 23:25 [PATCH 1/2] ASoC: Staticise CS4270 DAI Mark Brown
@ 2010-10-06 23:25 ` Mark Brown
  2010-10-07 18:13 ` [PATCH 1/2] ASoC: Staticise CS4270 DAI Liam Girdwood
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2010-10-06 23:25 UTC (permalink / raw)
  To: Liam Girdwood, Timur Tabi; +Cc: alsa-devel, patches, Mark Brown

It doesn't need to be exported with multi-component.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/ad1980.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/ad1980.c b/sound/soc/codecs/ad1980.c
index d36bd1c..410ccd5 100644
--- a/sound/soc/codecs/ad1980.c
+++ b/sound/soc/codecs/ad1980.c
@@ -133,7 +133,7 @@ static int ac97_write(struct snd_soc_codec *codec, unsigned int reg,
 	return 0;
 }
 
-struct snd_soc_dai_driver ad1980_dai = {
+static struct snd_soc_dai_driver ad1980_dai = {
 	.name = "ad1980-hifi",
 	.ac97_control = 1,
 	.playback = {
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ASoC: Staticise CS4270 DAI
  2010-10-06 23:25 [PATCH 1/2] ASoC: Staticise CS4270 DAI Mark Brown
  2010-10-06 23:25 ` [PATCH 2/2] ASoC: Staticise AD1980 DAI Mark Brown
@ 2010-10-07 18:13 ` Liam Girdwood
  2010-10-07 20:06 ` Timur Tabi
  2010-10-10 10:31 ` Liam Girdwood
  3 siblings, 0 replies; 5+ messages in thread
From: Liam Girdwood @ 2010-10-07 18:13 UTC (permalink / raw)
  To: Mark Brown; +Cc: alsa-devel, patches, Timur Tabi

On Wed, 2010-10-06 at 16:25 -0700, Mark Brown wrote:
> It's not needed with multi-component.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  sound/soc/codecs/cs4270.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c
> index 5fd8e0d..6d4bdc6 100644
> --- a/sound/soc/codecs/cs4270.c
> +++ b/sound/soc/codecs/cs4270.c
> @@ -518,7 +518,7 @@ static struct snd_soc_dai_ops cs4270_dai_ops = {
>  	.digital_mute	= cs4270_dai_mute,
>  };
>  
> -struct snd_soc_dai_driver cs4270_dai = {
> +static struct snd_soc_dai_driver cs4270_dai = {
>  	.name = "cs4270-hifi",
>  	.playback = {
>  		.stream_name = "Playback",

Both

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ASoC: Staticise CS4270 DAI
  2010-10-06 23:25 [PATCH 1/2] ASoC: Staticise CS4270 DAI Mark Brown
  2010-10-06 23:25 ` [PATCH 2/2] ASoC: Staticise AD1980 DAI Mark Brown
  2010-10-07 18:13 ` [PATCH 1/2] ASoC: Staticise CS4270 DAI Liam Girdwood
@ 2010-10-07 20:06 ` Timur Tabi
  2010-10-10 10:31 ` Liam Girdwood
  3 siblings, 0 replies; 5+ messages in thread
From: Timur Tabi @ 2010-10-07 20:06 UTC (permalink / raw)
  To: Mark Brown; +Cc: alsa-devel, patches, Liam Girdwood

Mark Brown wrote:
> It's not needed with multi-component.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Acked-by: Timur Tabi <timur@freescale.com>

-- 
Timur Tabi
Linux kernel developer at Freescale

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ASoC: Staticise CS4270 DAI
  2010-10-06 23:25 [PATCH 1/2] ASoC: Staticise CS4270 DAI Mark Brown
                   ` (2 preceding siblings ...)
  2010-10-07 20:06 ` Timur Tabi
@ 2010-10-10 10:31 ` Liam Girdwood
  3 siblings, 0 replies; 5+ messages in thread
From: Liam Girdwood @ 2010-10-10 10:31 UTC (permalink / raw)
  To: Mark Brown; +Cc: alsa-devel, patches, Timur Tabi

On Wed, 2010-10-06 at 16:25 -0700, Mark Brown wrote:
> It's not needed with multi-component.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---

Both 

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-10-10 10:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-06 23:25 [PATCH 1/2] ASoC: Staticise CS4270 DAI Mark Brown
2010-10-06 23:25 ` [PATCH 2/2] ASoC: Staticise AD1980 DAI Mark Brown
2010-10-07 18:13 ` [PATCH 1/2] ASoC: Staticise CS4270 DAI Liam Girdwood
2010-10-07 20:06 ` Timur Tabi
2010-10-10 10:31 ` Liam Girdwood

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.