All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
	drivers@analog.com,
	David Brownell <dbrownell@users.sourceforge.net>,
	linux-iio@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	matthias <mensch0815@googlemail.com>,
	spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 0/2 V2] Adding support for adis16250/5 to adis16260 driver.
Date: Fri, 08 Oct 2010 13:12:00 -0700	[thread overview]
Message-ID: <1286568720.1723.4.camel@helium> (raw)
In-Reply-To: <20101008182943.GJ3863@angua.secretlab.ca>

On Fri, 2010-10-08 at 12:29 -0600, Grant Likely wrote:
> On Fri, Oct 08, 2010 at 12:22:28PM +0100, Jonathan Cameron wrote:

> > Is it ever wrong to over specify elements of a transfer?

I wouldn't say that's even possible.

> > We have a driver that (for historical reasons) specifies
> > that a particular transfer is 8 bit.
> > 	.bits_per_word = 8,
> > 
> > This causes issues with the atmel spi driver which sees that
> > the value is specified and hence fails the transfer.


Specifying 8 there means the same as specifying zero.



WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: drivers-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org,
	David Brownell
	<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	matthias <mensch0815-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
	Nicolas Ferre
	<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
	Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH 0/2 V2] Adding support for adis16250/5 to adis16260 driver.
Date: Fri, 08 Oct 2010 13:12:00 -0700	[thread overview]
Message-ID: <1286568720.1723.4.camel@helium> (raw)
In-Reply-To: <20101008182943.GJ3863-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>

On Fri, 2010-10-08 at 12:29 -0600, Grant Likely wrote:
> On Fri, Oct 08, 2010 at 12:22:28PM +0100, Jonathan Cameron wrote:

> > Is it ever wrong to over specify elements of a transfer?

I wouldn't say that's even possible.

> > We have a driver that (for historical reasons) specifies
> > that a particular transfer is 8 bit.
> > 	.bits_per_word = 8,
> > 
> > This causes issues with the atmel spi driver which sees that
> > the value is specified and hence fails the transfer.


Specifying 8 there means the same as specifying zero.



------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb

  reply	other threads:[~2010-10-09  1:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-06 15:16 [PATCH 0/2 V2] Adding support for adis16250/5 to adis16260 driver Jonathan Cameron
2010-09-06 15:16 ` [PATCH 1/2] staging:iio:adis16260 add id table support Jonathan Cameron
2010-09-06 15:16 ` [PATCH 2/2] staging:iio:adis16260 add suppport for adis16255 and adis16250 Jonathan Cameron
2010-09-18 12:46 ` [PATCH 0/2 V2] Adding support for adis16250/5 to adis16260 driver Jonathan Cameron
2010-09-18 15:48   ` matthias
2010-09-27 16:34     ` Jonathan Cameron
2010-09-28 20:56       ` matthias
2010-09-29 13:52         ` Jonathan Cameron
2010-09-29 13:52           ` Jonathan Cameron
2010-10-08 11:22           ` Jonathan Cameron
2010-10-08 11:22             ` Jonathan Cameron
2010-10-08 18:29             ` Grant Likely
2010-10-08 18:29               ` Grant Likely
2010-10-08 20:12               ` David Brownell [this message]
2010-10-08 20:12                 ` David Brownell
2010-10-09 10:24                 ` Jonathan Cameron
2010-10-09 10:24                   ` Jonathan Cameron
     [not found]           ` <AANLkTikKQdxi3CWGinkJ6GMSmFZOLQ75-62LugkUAz-p@mail.gmail.com>
     [not found]             ` <4CB6E04F.4000208@cam.ac.uk>
     [not found]               ` <AANLkTikM4Cvr=utxCkUzyBPbm9gHkd_kTc0gpq3_Zurn@mail.gmail.com>
     [not found]                 ` <4CB6E93A.3080402@cam.ac.uk>
2010-11-12 17:10                   ` matthias
2010-11-18 14:18                     ` Jonathan Cameron
2010-11-23 17:47       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286568720.1723.4.camel@helium \
    --to=david-b@pacbell.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=drivers@analog.com \
    --cc=grant.likely@secretlab.ca \
    --cc=jic23@cam.ac.uk \
    --cc=linux-iio@vger.kernel.org \
    --cc=mensch0815@googlemail.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.