All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Ingo Molnar <mingo@elte.hu>,
	akpm@linux-foundation.org, mm-commits@vger.kernel.org,
	tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: + softirq-cleanup-preempt-check.patch added to -mm tree
Date: Sat, 09 Oct 2010 18:15:27 +0200	[thread overview]
Message-ID: <1286640927.1891.13.camel@laptop> (raw)
In-Reply-To: <4CAB92E9.7060509@suse.cz>

On Tue, 2010-10-05 at 23:04 +0200, Jiri Slaby wrote:
> >> +static inline void softirq_preempt_check(struct softirq_action *h,
> >> +            int prev_count)
> > 
> > unnecessary linebreak.
> 
> How unnecessary is this linebreak:
> $ wc -c
> static inline void softirq_preempt_check(struct softirq_action *h, int
> prev_count)
> 83
> 
> People, including me, still work with 80-col terminals. What I can
> tolerate are undivided strings, because it sucks if one cannot grep for
> anything from the log 

I actually work on ~350 character wide terminals, but then, I vert-split
it 4-ways so I end up with ~85 chars per column.. :-)

But I agree the line should be split, I however much prefer the form:

static inline
void softirq_preempt_check(struct softirq_action *h, int prev_count)



  reply	other threads:[~2010-10-09 16:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-05 19:05 + softirq-cleanup-preempt-check.patch added to -mm tree akpm
2010-10-05 19:38 ` Ingo Molnar
2010-10-05 21:04   ` Jiri Slaby
2010-10-09 16:15     ` Peter Zijlstra [this message]
2010-10-20  9:33       ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286640927.1891.13.camel@laptop \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mm-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.