From: Jiri Slaby <jslaby@suse.cz>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
akpm@linux-foundation.org, mm-commits@vger.kernel.org,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: + softirq-cleanup-preempt-check.patch added to -mm tree
Date: Wed, 20 Oct 2010 11:33:27 +0200 [thread overview]
Message-ID: <4CBEB767.7030404@suse.cz> (raw)
In-Reply-To: <1286640927.1891.13.camel@laptop>
On 10/09/2010 06:15 PM, Peter Zijlstra wrote:
> But I agree the line should be split, I however much prefer the form:
>
> static inline
> void softirq_preempt_check(struct softirq_action *h, int prev_count)
Ok I can do that while I'm ratelimiting the message. When this error
occurs, it floods the kmsg quite a lot for works like netif_rx.
thanks,
--
js
suse labs
prev parent reply other threads:[~2010-10-20 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 19:05 + softirq-cleanup-preempt-check.patch added to -mm tree akpm
2010-10-05 19:38 ` Ingo Molnar
2010-10-05 21:04 ` Jiri Slaby
2010-10-09 16:15 ` Peter Zijlstra
2010-10-20 9:33 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBEB767.7030404@suse.cz \
--to=jslaby@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mm-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.