All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fbdev: sh_mobile_hdmi: fix compilation without SOUND enabled
@ 2010-10-15  6:58 ` Guennadi Liakhovetski
  0 siblings, 0 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2010-10-15  6:58 UTC (permalink / raw)
  To: linux-sh
  Cc: alsa-devel, Kuninori Morimoto, Liam Girdwood, Mark Brown,
	Paul Mundt

At least two more Kconfig options have to be selected to be able to compile
sh_mobile_hdmi.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---

Liam, Mark: since this patch only touches drivers/video, although that's a 
central commonly-used file there, the scope of this patch is limited to 
the FB_SH_MOBILE_HDMI block, so, this should safe to go via an SH tree, 
but, if Paul doesn't mind, it should also be ok to go via sound.

 drivers/video/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 43e90b8..935cdc2 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1919,6 +1919,8 @@ config FB_SH_MOBILE_HDMI
 	tristate "SuperH Mobile HDMI controller support"
 	depends on FB_SH_MOBILE_LCDC
 	select FB_MODE_HELPERS
+	select SOUND
+	select SND
 	select SND_SOC
 	---help---
 	  Driver for the on-chip SH-Mobile HDMI controller.
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] fbdev: sh_mobile_hdmi: fix compilation without SOUND enabled
@ 2010-10-15  6:58 ` Guennadi Liakhovetski
  0 siblings, 0 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2010-10-15  6:58 UTC (permalink / raw)
  To: linux-sh
  Cc: alsa-devel, Kuninori Morimoto, Liam Girdwood, Mark Brown,
	Paul Mundt

At least two more Kconfig options have to be selected to be able to compile
sh_mobile_hdmi.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---

Liam, Mark: since this patch only touches drivers/video, although that's a 
central commonly-used file there, the scope of this patch is limited to 
the FB_SH_MOBILE_HDMI block, so, this should safe to go via an SH tree, 
but, if Paul doesn't mind, it should also be ok to go via sound.

 drivers/video/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 43e90b8..935cdc2 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1919,6 +1919,8 @@ config FB_SH_MOBILE_HDMI
 	tristate "SuperH Mobile HDMI controller support"
 	depends on FB_SH_MOBILE_LCDC
 	select FB_MODE_HELPERS
+	select SOUND
+	select SND
 	select SND_SOC
 	---help---
 	  Driver for the on-chip SH-Mobile HDMI controller.
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] fbdev: sh_mobile_hdmi: fix compilation without SOUND enabled
  2010-10-15  6:58 ` Guennadi Liakhovetski
@ 2010-10-15 10:56   ` Liam Girdwood
  -1 siblings, 0 replies; 6+ messages in thread
From: Liam Girdwood @ 2010-10-15 10:56 UTC (permalink / raw)
  To: Guennadi Liakhovetski
  Cc: alsa-devel, Morimoto, linux-sh, Mark Brown, Kuninori, Paul Mundt

On Fri, 2010-10-15 at 08:58 +0200, Guennadi Liakhovetski wrote:
> At least two more Kconfig options have to be selected to be able to compile
> sh_mobile_hdmi.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> 
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] fbdev: sh_mobile_hdmi: fix compilation without SOUND
@ 2010-10-15 10:56   ` Liam Girdwood
  0 siblings, 0 replies; 6+ messages in thread
From: Liam Girdwood @ 2010-10-15 10:56 UTC (permalink / raw)
  To: Guennadi Liakhovetski
  Cc: alsa-devel, Morimoto, linux-sh, Mark Brown, Kuninori, Paul Mundt

On Fri, 2010-10-15 at 08:58 +0200, Guennadi Liakhovetski wrote:
> At least two more Kconfig options have to be selected to be able to compile
> sh_mobile_hdmi.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> 
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] fbdev: sh_mobile_hdmi: fix compilation without SOUND enabled
  2010-10-15  6:58 ` Guennadi Liakhovetski
@ 2010-10-15 10:57   ` Mark Brown
  -1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2010-10-15 10:57 UTC (permalink / raw)
  To: Guennadi Liakhovetski
  Cc: linux-sh, alsa-devel, Kuninori Morimoto, Liam Girdwood,
	Paul Mundt

On Fri, Oct 15, 2010 at 08:58:00AM +0200, Guennadi Liakhovetski wrote:
> At least two more Kconfig options have to be selected to be able to compile
> sh_mobile_hdmi.

Applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] fbdev: sh_mobile_hdmi: fix compilation without SOUND
@ 2010-10-15 10:57   ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2010-10-15 10:57 UTC (permalink / raw)
  To: Guennadi Liakhovetski
  Cc: linux-sh, alsa-devel, Kuninori Morimoto, Liam Girdwood,
	Paul Mundt

On Fri, Oct 15, 2010 at 08:58:00AM +0200, Guennadi Liakhovetski wrote:
> At least two more Kconfig options have to be selected to be able to compile
> sh_mobile_hdmi.

Applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-10-15 10:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-15  6:58 [PATCH] fbdev: sh_mobile_hdmi: fix compilation without SOUND enabled Guennadi Liakhovetski
2010-10-15  6:58 ` Guennadi Liakhovetski
2010-10-15 10:56 ` Liam Girdwood
2010-10-15 10:56   ` [PATCH] fbdev: sh_mobile_hdmi: fix compilation without SOUND Liam Girdwood
2010-10-15 10:57 ` [PATCH] fbdev: sh_mobile_hdmi: fix compilation without SOUND enabled Mark Brown
2010-10-15 10:57   ` [PATCH] fbdev: sh_mobile_hdmi: fix compilation without SOUND Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.