From: Vasiliy Kulikov <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: Dan Williams <dan.j.williams@intel.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] dma: imx-dma: fix signedness bug
Date: Sun, 17 Oct 2010 14:51:50 +0000 [thread overview]
Message-ID: <1287327110-9158-1-git-send-email-segooon@gmail.com> (raw)
mxdmac->channel was unsigned, so check (imxdmac->channel < 0) for
failed imx_dma_request_by_prio() made no sence. Explicitly check
signed values.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
drivers/dma/imx-dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
index 346be62..75d870f 100644
--- a/drivers/dma/imx-dma.c
+++ b/drivers/dma/imx-dma.c
@@ -335,7 +335,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
imxdmac->imxdma_channel = imx_dma_request_by_prio("dmaengine",
DMA_PRIO_MEDIUM);
- if (imxdmac->channel < 0)
+ if ((int)imxdmac->channel < 0)
goto err_init;
imx_dma_setup_handlers(imxdmac->imxdma_channel,
--
1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: Vasiliy Kulikov <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: Dan Williams <dan.j.williams@intel.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] dma: imx-dma: fix signedness bug
Date: Sun, 17 Oct 2010 18:51:50 +0400 [thread overview]
Message-ID: <1287327110-9158-1-git-send-email-segooon@gmail.com> (raw)
mxdmac->channel was unsigned, so check (imxdmac->channel < 0) for
failed imx_dma_request_by_prio() made no sence. Explicitly check
signed values.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
drivers/dma/imx-dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
index 346be62..75d870f 100644
--- a/drivers/dma/imx-dma.c
+++ b/drivers/dma/imx-dma.c
@@ -335,7 +335,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
imxdmac->imxdma_channel = imx_dma_request_by_prio("dmaengine",
DMA_PRIO_MEDIUM);
- if (imxdmac->channel < 0)
+ if ((int)imxdmac->channel < 0)
goto err_init;
imx_dma_setup_handlers(imxdmac->imxdma_channel,
--
1.7.0.4
next reply other threads:[~2010-10-17 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-17 14:51 Vasiliy Kulikov [this message]
2010-10-17 14:51 ` [PATCH] dma: imx-dma: fix signedness bug Vasiliy Kulikov
2010-10-18 8:02 ` Sascha Hauer
2010-10-18 8:02 ` Sascha Hauer
2010-10-19 22:26 ` Dan Williams
2010-10-19 22:26 ` Dan Williams
2010-10-20 6:35 ` Sascha Hauer
2010-10-20 6:35 ` Sascha Hauer
2010-10-20 6:37 ` Sascha Hauer
2010-10-20 6:37 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287327110-9158-1-git-send-email-segooon@gmail.com \
--to=segooon@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.