From: John Bonesio <bones-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 2/2] Allow nodes at the root to be specified by path as well as by label.
Date: Tue, 19 Oct 2010 09:05:55 -0700 [thread overview]
Message-ID: <1287504355.4535.1465.camel@riker> (raw)
In-Reply-To: <20101019021411.GA24726@yookeroo>
On Tue, 2010-10-19 at 13:14 +1100, David Gibson wrote:
> On Mon, Oct 18, 2010 at 01:25:50PM -0700, John Bonesio wrote:
> > Changes to allow us to specify a node by it's path. A path can be used in
> > place of a label.
> >
> > This is particularly useful when overriding existing nodes.
> > This way we don't have to label every possible node in a device tree we know
> > is a base device tree for a class of systems, and we know the tree will be
> > modified for the specific systems.
>
> Nack. This patch is pointless, the DT_REF lexing will already resolve
> paths in the form &{/some/path} and I see no reason that won't work
> for tree merging as well. Oh, and bare &/path/to/node is a bad idea
> anyway, more about that later.
>
I believe a patch is still necessary. I just tried dtc from git without
changes. I didn't work.
It also looks to me like get_node_by_label() will not resolve nodes that
are specified by path.
Perhaps I'm just doing something wrong.
- John
next prev parent reply other threads:[~2010-10-19 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 20:25 [PATCH 1/2] Implements new features for updating existing device tree nodes John Bonesio
2010-10-18 20:25 ` [PATCH 2/2] Allow nodes at the root to be specified by path as well as by label John Bonesio
2010-10-18 20:50 ` Grant Likely
[not found] ` <AANLkTimi_w-3pd9U6mKj5A78RzOp2KdBvh3fqgNTFBqH@mail.gmail.com>
[not found] ` <20101018215143.GC3337@angua.secretlab.ca>
[not found] ` <20101018215143.GC3337-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-10-18 23:36 ` John Bonesio
[not found] ` <AANLkTimT6WaCDgLM-cqEvrUqTmeDDohOGEgxDXjxssPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-19 2:33 ` David Gibson
2010-10-23 23:14 ` node reference: path from a label John Bonesio
2010-10-25 4:26 ` David Gibson
2010-11-02 4:42 ` Grant Likely
2010-10-19 2:14 ` [PATCH 2/2] Allow nodes at the root to be specified by path as well as by label David Gibson
2010-10-19 16:05 ` John Bonesio [this message]
2010-10-19 21:51 ` David Gibson
2010-10-18 20:42 ` [PATCH 1/2] Implements new features for updating existing device tree nodes Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287504355.4535.1465.camel@riker \
--to=bones-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.