Re: [PATCH 2/2] Allow nodes at the root to be specified by path as well as by label.

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

On Tue, Oct 19, 2010 at 09:05:55AM -0700, John Bonesio wrote:
> On Tue, 2010-10-19 at 13:14 +1100, David Gibson wrote:
> > On Mon, Oct 18, 2010 at 01:25:50PM -0700, John Bonesio wrote:
> > > Changes to allow us to specify a node by it's path. A path can be used in
> > > place of a label.
> > > 
> > > This is particularly useful when overriding existing nodes.
> > > This way we don't have to label every possible node in a device tree we know
> > > is a base device tree for a class of systems, and we know the tree will be
> > > modified for the specific systems.
> > 
> > Nack.  This patch is pointless, the DT_REF lexing will already resolve
> > paths in the form &{/some/path} and I see no reason that won't work
> > for tree merging as well.  Oh, and bare &/path/to/node is a bad idea
> > anyway, more about that later.
> 
> I believe a patch is still necessary. I just tried dtc from git without
> changes. I didn't work.
> 
> It also looks to me like get_node_by_label() will not resolve nodes that
> are specified by path.
> 
> Perhaps I'm just doing something wrong.

Ah, yes, sorry.  The grammar will accept the full path, but
get_node_by_label() won't look it up.  If you change that to
get_node_by_ref(), however, I think it should work.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson