From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB: fix Queue Element Transfer Descriptor changes
Date: Wed, 20 Oct 2010 21:08:17 +0200 [thread overview]
Message-ID: <1287601697-30255-1-git-send-email-wd@denx.de> (raw)
In-Reply-To: <k2pf8955f9e1004080804ha6871d1ep3b7fa6b8671a02d8@mail.gmail.com>
Commit 3ed1607 "USB: sync Queue Element Transfer Descriptor against
EHCI spec" added an "__attribute__ ((aligned (32)))" to the
declaration of struct qTD, as used for example in the Linux kernel as
well.
However, it turns out that this attribute causes errors in "usb start"
(like "ERROR: NOT USB_CONFIG_DESC 7b" and similar). Drop the attribute
again.
Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Dan Lykowski <lykowdk@gmail.com>
Cc: Remy Bohmer <linux@bohmer.net>
Cc: Stefano Babic <sbabic@denx.de>
---
drivers/usb/host/ehci.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index d3aa55b..945ab64 100644
--- a/drivers/usb/host/ehci.h
+++ b/drivers/usb/host/ehci.h
@@ -175,7 +175,7 @@ struct qTD {
uint32_t qt_buffer_hi[5]; /* Appendix B */
/* pad struct for 32 byte alignment */
uint32_t unused[3];
-} __attribute__ ((aligned (32)));
+};
/* Queue Head (QH). */
struct QH {
--
1.7.2.3
next prev parent reply other threads:[~2010-10-20 19:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 15:04 [U-Boot] usb EHCI failing with 'EHCI fail timeout STD_ASS reset' Dan Lykowski
2010-10-19 14:13 ` [U-Boot] [PATCH] USB: sync Queue Element Transfer Descriptor against EHCI spec Wolfgang Denk
2010-10-19 22:26 ` Wolfgang Denk
2010-10-20 3:20 ` [U-Boot] Data bus error sywang
2010-10-20 9:27 ` [U-Boot] [PATCH] USB: sync Queue Element Transfer Descriptor against EHCI spec Remy Bohmer
2010-10-20 18:52 ` Wolfgang Denk
2010-10-20 19:08 ` Wolfgang Denk [this message]
2010-10-21 9:17 ` [U-Boot] [PATCH] USB: fix Queue Element Transfer Descriptor changes Remy Bohmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287601697-30255-1-git-send-email-wd@denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.