All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB: sync Queue Element Transfer Descriptor against EHCI spec
Date: Wed, 20 Oct 2010 00:26:35 +0200	[thread overview]
Message-ID: <20101019222635.56FC71359B7@gemini.denx.de> (raw)
In-Reply-To: <1287497595-22758-1-git-send-email-wd@denx.de>


In message <1287497595-22758-1-git-send-email-wd@denx.de> I wrote:
> Appendix B "EHCI 64-Bit Data Structures" of the "Enhanced Host
> Controller Interface Specification for Universal Serial Bus" (Rev.
> 1.0, March 12, 2002) defines additional fields which were missing in
> U-Boot's struct qTD; as these are also present in recent versions of
> struct ehci_qtd in the Linux kernel, we add them here, too.
> 
> This fixes some nasty memory corruption problems.
> 
> Reported-by: Dan Lykowski <lykowdk@gmail.com>
> See http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/76942
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Remy Bohmer <linux@bohmer.net>
> Cc: Dan Lykowski <lykowdk@gmail.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Tested-by: Stefano Babic <sbabic@denx.de>
> ---
> 
> Dear Remy,
> 
> this patch goes back to an old posting by Dan Lykowski.
> 
> Unfortunately Dan never submitted a patch, so this went unfixed until
> now, when the bug bit Stefano...
> 
> Best regards,
> 
> Wolfgang
> 
> 
>  drivers/usb/host/ehci-hcd.c |    1 +
>  drivers/usb/host/ehci.h     |   14 +++++++++-----
>  2 files changed, 10 insertions(+), 5 deletions(-)

Applied directly.

Remy, I hope this is OK with you.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I must follow the people.  Am I not their leader? - Benjamin Disraeli

  reply	other threads:[~2010-10-19 22:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 15:04 [U-Boot] usb EHCI failing with 'EHCI fail timeout STD_ASS reset' Dan Lykowski
2010-10-19 14:13 ` [U-Boot] [PATCH] USB: sync Queue Element Transfer Descriptor against EHCI spec Wolfgang Denk
2010-10-19 22:26   ` Wolfgang Denk [this message]
2010-10-20  3:20     ` [U-Boot] Data bus error sywang
2010-10-20  9:27     ` [U-Boot] [PATCH] USB: sync Queue Element Transfer Descriptor against EHCI spec Remy Bohmer
2010-10-20 18:52       ` Wolfgang Denk
2010-10-20 19:08 ` [U-Boot] [PATCH] USB: fix Queue Element Transfer Descriptor changes Wolfgang Denk
2010-10-21  9:17   ` Remy Bohmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101019222635.56FC71359B7@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.