All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Liu <lliubbo@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, fengguang.wu@intel.com,
	kamezawa.hiroyu@jp.fujitsu.com, mel@csn.ul.ie,
	kosaki.motohiro@jp.fujitsu.com, Bob Liu <lliubbo@gmail.com>
Subject: [PATCH 1/3] page_isolation: codeclean fix comment and rm unneeded val init
Date: Thu, 21 Oct 2010 21:28:19 +0800	[thread overview]
Message-ID: <1287667701-8081-1-git-send-email-lliubbo@gmail.com> (raw)

function __test_page_isolated_in_pageblock() return 1 if all pages
in the range is isolated, so fix the comment.
value pfn will be init in the following loop so rm it.

Signed-off-by: Bob Liu <lliubbo@gmail.com>
---
 mm/page_isolation.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/mm/page_isolation.c b/mm/page_isolation.c
index 5e0ffd9..4ae42bb 100644
--- a/mm/page_isolation.c
+++ b/mm/page_isolation.c
@@ -86,7 +86,7 @@ undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn)
  * all pages in [start_pfn...end_pfn) must be in the same zone.
  * zone->lock must be held before call this.
  *
- * Returns 0 if all pages in the range is isolated.
+ * Returns 1 if all pages in the range is isolated.
  */
 static int
 __test_page_isolated_in_pageblock(unsigned long pfn, unsigned long end_pfn)
@@ -119,7 +119,6 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn)
 	struct zone *zone;
 	int ret;
 
-	pfn = start_pfn;
 	/*
 	 * Note: pageblock_nr_page != MAX_ORDER. Then, chunks of free page
 	 * is not aligned to pageblock_nr_pages.
-- 
1.5.6.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2010-10-21 13:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-21 13:28 Bob Liu [this message]
2010-10-21 13:28 ` [PATCH 2/3] do_migrate_range: exit loop if not_managed is true Bob Liu
2010-10-21 13:28   ` [PATCH 3/3] do_migrate_range: reduce list_empty() check Bob Liu
2010-10-22  3:17     ` KAMEZAWA Hiroyuki
2010-10-25  6:02     ` Wu Fengguang
2010-10-25 21:36     ` Andrew Morton
2010-10-21 14:25   ` [PATCH 2/3] do_migrate_range: exit loop if not_managed is true Wu Fengguang
2010-10-22  2:48     ` Bob Liu
2010-10-22  3:22       ` Wu Fengguang
2010-10-22  8:41         ` Bob Liu
2010-10-22 10:23           ` Wu Fengguang
2010-10-22  3:16   ` KAMEZAWA Hiroyuki
2010-10-22  8:41     ` Bob Liu
2010-10-22  8:43       ` KAMEZAWA Hiroyuki
2010-10-25  5:51   ` Wu Fengguang
2010-10-21 14:01 ` [PATCH 1/3] page_isolation: codeclean fix comment and rm unneeded val init Wu Fengguang
2010-10-22  2:34   ` Bob Liu
2010-10-22  3:13     ` Wu Fengguang
2010-10-22  3:12 ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287667701-8081-1-git-send-email-lliubbo@gmail.com \
    --to=lliubbo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.