Re: [PATCH 1/3] page_isolation: codeclean fix comment and rm unneeded val init

[Wu Fengguang <fengguang.wu@intel.com>]

On Fri, Oct 22, 2010 at 10:34:01AM +0800, Bob Liu wrote:
> On Thu, Oct 21, 2010 at 10:01 PM, Wu Fengguang <fengguang.wu@intel.com> wrote:
> > On Thu, Oct 21, 2010 at 09:28:19PM +0800, Bob Liu wrote:
> >> function __test_page_isolated_in_pageblock() return 1 if all pages
> >> in the range is isolated, so fix the comment.
> >> value pfn will be init in the following loop so rm it.
> >
> > This is a bit confusing, but the original comment should be intended
> > for test_pages_isolated()..
> 
> Maybe it used to but now it said "zone->lock must be held before call this",
> so it is the comment for __test_page_isolated_in_pageblock() nomore
> test_pages_isolated(),
> so fix the comment as this patch did.

OK.

The comment still looks a bit awkward though. There are
redundant/inconsistent "... range is free(means isolated) or not",
"... range is isolated." and "all pages are free or Marked as
ISOLATED". And the "start_pfn" is only found in test_pages_isolated().

Thanks,
Fengguang

> >> Signed-off-by: Bob Liu <lliubbo@gmail.com>
> >> ---
> >> A mm/page_isolation.c | A  A 3 +--
> >> A 1 files changed, 1 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
> >> index 5e0ffd9..4ae42bb 100644
> >> --- a/mm/page_isolation.c
> >> +++ b/mm/page_isolation.c
> >> @@ -86,7 +86,7 @@ undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn)
> >> A  * all pages in [start_pfn...end_pfn) must be in the same zone.
> >> A  * zone->lock must be held before call this.
> >> A  *
> >> - * Returns 0 if all pages in the range is isolated.
> >> + * Returns 1 if all pages in the range is isolated.
> >> A  */
> >> A static int
> >> A __test_page_isolated_in_pageblock(unsigned long pfn, unsigned long end_pfn)
> >> @@ -119,7 +119,6 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn)
> >> A  A  A  struct zone *zone;
> >> A  A  A  int ret;
> >>
> >> - A  A  pfn = start_pfn;
> >> A  A  A  /*
> >> A  A  A  A * Note: pageblock_nr_page != MAX_ORDER. Then, chunks of free page
> >> A  A  A  A * is not aligned to pageblock_nr_pages.
> >> --
> >> 1.5.6.3
> >
> -- 
> Regards,
> --Bob

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>