All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: linux-mmc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, shawn.gsc@gmail.com,
	w.sang@pengutronix.de, nicolas.pitre@linaro.org,
	r65037@freescale.com, amit.kucheria@linaro.org,
	"Eric Bénard" <eric@eukrea.com>
Subject: [PATCH 2/2] sdhci-esdhc-imx: enable QUIRK_NO_MULTIBLOCK only for i.MX25 and i.MX35
Date: Thu, 21 Oct 2010 23:20:28 +0200	[thread overview]
Message-ID: <1287696028-27854-2-git-send-email-eric@eukrea.com> (raw)
In-Reply-To: <4CC0A281.1010202@eukrea.com>

only these CPU's errata list this bug.

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 drivers/mmc/host/sdhci-esdhc-imx.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 11e1ae1..4d67f58 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -136,6 +136,12 @@ static int esdhc_pltfm_init(struct sdhci_host *host, struct sdhci_pltfm_data *pd
 		host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
 	}
 
+	/* fix errata ENGcm07207 which is present on i.MX25 and i.MX35 */
+	if (cpu_is_mx25() || cpu_is_mx35()) {
+		dev_info(mmc_dev(host->mmc), "using ENGcm07207 workaround\n");
+		host->quirks |= SDHCI_QUIRK_NO_MULTIBLOCK;
+	}
+
 	return 0;
 }
 
@@ -162,10 +168,8 @@ static struct sdhci_ops sdhci_esdhc_ops = {
 };
 
 struct sdhci_pltfm_data sdhci_esdhc_imx_pdata = {
-	.quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_NO_MULTIBLOCK
-			| SDHCI_QUIRK_BROKEN_ADMA,
+	.quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_BROKEN_ADMA,
 	/* ADMA has issues. Might be fixable */
-	/* NO_MULTIBLOCK might be MX35 only (Errata: ENGcm07207) */
 	.ops = &sdhci_esdhc_ops,
 	.init = esdhc_pltfm_init,
 	.exit = esdhc_pltfm_exit,
-- 
1.7.0.4


WARNING: multiple messages have this Message-ID (diff)
From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] sdhci-esdhc-imx: enable QUIRK_NO_MULTIBLOCK only for i.MX25 and i.MX35
Date: Thu, 21 Oct 2010 23:20:28 +0200	[thread overview]
Message-ID: <1287696028-27854-2-git-send-email-eric@eukrea.com> (raw)
In-Reply-To: <4CC0A281.1010202@eukrea.com>

only these CPU's errata list this bug.

Signed-off-by: Eric B?nard <eric@eukrea.com>
---
 drivers/mmc/host/sdhci-esdhc-imx.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 11e1ae1..4d67f58 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -136,6 +136,12 @@ static int esdhc_pltfm_init(struct sdhci_host *host, struct sdhci_pltfm_data *pd
 		host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
 	}
 
+	/* fix errata ENGcm07207 which is present on i.MX25 and i.MX35 */
+	if (cpu_is_mx25() || cpu_is_mx35()) {
+		dev_info(mmc_dev(host->mmc), "using ENGcm07207 workaround\n");
+		host->quirks |= SDHCI_QUIRK_NO_MULTIBLOCK;
+	}
+
 	return 0;
 }
 
@@ -162,10 +168,8 @@ static struct sdhci_ops sdhci_esdhc_ops = {
 };
 
 struct sdhci_pltfm_data sdhci_esdhc_imx_pdata = {
-	.quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_NO_MULTIBLOCK
-			| SDHCI_QUIRK_BROKEN_ADMA,
+	.quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_BROKEN_ADMA,
 	/* ADMA has issues. Might be fixable */
-	/* NO_MULTIBLOCK might be MX35 only (Errata: ENGcm07207) */
 	.ops = &sdhci_esdhc_ops,
 	.init = esdhc_pltfm_init,
 	.exit = esdhc_pltfm_exit,
-- 
1.7.0.4

  parent reply	other threads:[~2010-10-21 21:20 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-20  8:53 [PATCH 0/2] babbage: support mmc device Shawn Guo
2010-10-20  9:22 ` [PATCH 1/2] mmc: quirk fix for timeout problem Shawn Guo
2010-10-20 11:27   ` Wolfram Sang
2010-10-21 16:11     ` Shawn Guo
2010-10-21 16:43       ` Wolfram Sang
2010-10-21 17:10       ` Nicolas Pitre
2010-10-21 18:14         ` Shawn Guo
2010-10-21 20:28           ` Eric Bénard
2010-10-21 21:20             ` [PATCH 1/2] sdhci-esdhc-imx: fix timeout on i.MX's sdhci Eric Bénard
2010-10-21 21:20               ` Eric Bénard
2010-10-22  6:15               ` Wolfram Sang
2010-10-22  6:15                 ` Wolfram Sang
2010-10-22 23:12               ` Chris Ball
2010-10-22 23:12                 ` Chris Ball
2010-10-22 23:57                 ` Eric Bénard
2010-10-22 23:57                   ` Eric Bénard
2010-11-07 22:51                   ` Chris Ball
2010-11-07 22:51                     ` Chris Ball
2010-10-22 23:57                 ` [PATCH 2/2] sdhci-esdhc-imx: enable QUIRK_NO_MULTIBLOCK only for i.MX25 and i.MX35 Eric Bénard
2010-10-22 23:57                   ` Eric Bénard
2010-10-21 21:20             ` Eric Bénard [this message]
2010-10-21 21:20               ` Eric Bénard
2010-10-22  6:18               ` Wolfram Sang
2010-10-22  6:18                 ` Wolfram Sang
2010-10-22  7:07                 ` Eric Bénard
2010-10-22  7:07                   ` Eric Bénard
2010-10-22  8:46                 ` [PATCH v2 1/2] sdhci-esdhc-imx: fix timeout on i.MX's sdhci Eric Bénard
2010-10-22  8:46                   ` Eric Bénard
2010-10-22  8:46                 ` [PATCH v2 2/2] sdhci-esdhc-imx: enable QUIRK_NO_MULTIBLOCK only for i.MX25 and i.MX35 Eric Bénard
2010-10-22  8:46                   ` Eric Bénard
2010-10-22 10:54                   ` Wolfram Sang
2010-10-22 10:54                     ` Wolfram Sang
2010-10-22  4:39             ` [PATCH 1/2] mmc: quirk fix for timeout problem Shawn Guo
2010-10-20  9:24 ` [PATCH 2/2] babbage: esdhc device registration Shawn Guo
2010-10-20 11:30   ` Wolfram Sang
2010-10-20 11:52   ` Amit Kucheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287696028-27854-2-git-send-email-eric@eukrea.com \
    --to=eric@eukrea.com \
    --cc=amit.kucheria@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=r65037@freescale.com \
    --cc=shawn.gsc@gmail.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.