From: Davidlohr Bueso <dave@gnu.org>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dave Airlie <airlied@redhat.com>, Dave Airlie <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH RESEND] drm: include missing types header to drm_mode.h
Date: Sun, 24 Oct 2010 23:13:40 -0300 [thread overview]
Message-ID: <1287972820.2047.0.camel@cowboy> (raw)
In-Reply-To: <20101022170255.7feab5de.rdunlap@xenotime.net>
On Fri, 2010-10-22 at 17:02 -0700, Randy Dunlap wrote:
> On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:
>
> > On Fri, 22 Oct 2010 10:13:19 -0300
> > Davidlohr Bueso <dave@gnu.org> wrote:
> >
> > > drm: include missing types header to drm_mode.h
> > >
> > > Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> > > ---
> > > include/drm/drm_mode.h | 2 ++
> > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
> > > index 0fc7397..eddd7f4 100644
> > > --- a/include/drm/drm_mode.h
> > > +++ b/include/drm/drm_mode.h
> > > @@ -24,6 +24,8 @@
> > > * IN THE SOFTWARE.
> > > */
> > >
> > > +#include <linux/types.h>
> > > +
> > > #ifndef _DRM_MODE_H
> > > #define _DRM_MODE_H
> > >
> >
> > Does this fix a build error? If so, please send along the compiler
> > error output.
>
>
> Every build that has CONFIG_HEADERS_CHECK=y reports the following:
>
> linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-next-20101022/X64/usr/include/linux/resource.h:49: found __[us]{8,16,32,64} type without #include <linux/types.h>
>
Yeah that's what made me send the patch.
Thanks,
Davidlohr
WARNING: multiple messages have this Message-ID (diff)
From: Davidlohr Bueso <dave@gnu.org>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Dave Airlie <airlied@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH RESEND] drm: include missing types header to drm_mode.h
Date: Sun, 24 Oct 2010 23:13:40 -0300 [thread overview]
Message-ID: <1287972820.2047.0.camel@cowboy> (raw)
In-Reply-To: <20101022170255.7feab5de.rdunlap@xenotime.net>
On Fri, 2010-10-22 at 17:02 -0700, Randy Dunlap wrote:
> On Fri, 22 Oct 2010 16:55:17 -0700 Andrew Morton wrote:
>
> > On Fri, 22 Oct 2010 10:13:19 -0300
> > Davidlohr Bueso <dave@gnu.org> wrote:
> >
> > > drm: include missing types header to drm_mode.h
> > >
> > > Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> > > ---
> > > include/drm/drm_mode.h | 2 ++
> > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
> > > index 0fc7397..eddd7f4 100644
> > > --- a/include/drm/drm_mode.h
> > > +++ b/include/drm/drm_mode.h
> > > @@ -24,6 +24,8 @@
> > > * IN THE SOFTWARE.
> > > */
> > >
> > > +#include <linux/types.h>
> > > +
> > > #ifndef _DRM_MODE_H
> > > #define _DRM_MODE_H
> > >
> >
> > Does this fix a build error? If so, please send along the compiler
> > error output.
>
>
> Every build that has CONFIG_HEADERS_CHECK=y reports the following:
>
> linux-next-20101022/X64/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-next-20101022/X64/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-next-20101022/X64/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-next-20101022/X64/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-next-20101022/X64/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-next-20101022/X64/usr/include/scsi/scsi_netlink.h:108: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-next-20101022/X64/usr/include/linux/resource.h:49: found __[us]{8,16,32,64} type without #include <linux/types.h>
>
Yeah that's what made me send the patch.
Thanks,
Davidlohr
next prev parent reply other threads:[~2010-10-25 2:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 13:13 [PATCH RESEND] drm: include missing types header to drm_mode.h Davidlohr Bueso
2010-10-22 13:13 ` Davidlohr Bueso
2010-10-22 23:55 ` Andrew Morton
2010-10-22 23:55 ` Andrew Morton
2010-10-23 0:02 ` Randy Dunlap
2010-10-23 0:02 ` Randy Dunlap
2010-10-23 0:19 ` Dave Airlie
2010-10-23 0:19 ` Dave Airlie
2010-10-25 2:13 ` Davidlohr Bueso [this message]
2010-10-25 2:13 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287972820.2047.0.camel@cowboy \
--to=dave@gnu.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.