From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: Tony Lindgren <tony@atomide.com>,
Kevin Hilman <khilman@deeprootsystems.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kalle Jokiniemi <kalle.jokiniemi@digia.com>,
Rajendra Nayak <rnayak@ti.com>,
Felipe Contreras <felipe.contreras@gmail.com>,
Tero Kristo <tero.kristo@nokia.com>,
Fernando Guzman Lugo <x0095840@ti.com>,
Rene Sapiens <rene.sapiens@ti.com>,
Ernesto Ramos <ernesto@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Paul Walmsley <paul@pwsan.com>,
Omar Ramirez Luna <omar.ramirez@ti.com>
Subject: [PATCH v2 4/4] staging: tidspbridge: use new SCM DSP boot control fns
Date: Tue, 26 Oct 2010 11:16:03 -0500 [thread overview]
Message-ID: <1288109763-9446-5-git-send-email-omar.ramirez@ti.com> (raw)
In-Reply-To: <1288109763-9446-1-git-send-email-omar.ramirez@ti.com>
From: Paul Walmsley <paul@pwsan.com>
Use the new functions from SCM layer instead of handling registers
directly with __raw_writel, as explained in:
http://marc.info/?l=linux-omap&m=128779652429922&w=2
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
drivers/staging/tidspbridge/core/tiomap3430.c | 13 ++++++-------
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c
index f22bc12..b91d911 100644
--- a/drivers/staging/tidspbridge/core/tiomap3430.c
+++ b/drivers/staging/tidspbridge/core/tiomap3430.c
@@ -23,7 +23,7 @@
#include <dspbridge/host_os.h>
#include <linux/mm.h>
#include <linux/mmzone.h>
-#include <plat/control.h>
+#include <plat/iva2_dsp.h>
/* ----------------------------------- DSP/BIOS Bridge */
#include <dspbridge/dbdefs.h>
@@ -293,6 +293,7 @@ static int bridge_brd_start(struct bridge_dev_context *dev_ctxt,
u32 clk_cmd;
struct io_mgr *hio_mgr;
u32 ul_load_monitor_timer;
+ u8 bootmode;
struct omap_dsp_platform_data *pdata =
omap_dspbridge_dev->dev.platform_data;
@@ -334,15 +335,13 @@ static int bridge_brd_start(struct bridge_dev_context *dev_ctxt,
OMAP3430_RST1_IVA2_MASK, OMAP3430_IVA2_MOD,
OMAP2_RM_RSTCTRL);
/* Mask address with 1K for compatibility */
- __raw_writel(dsp_addr & OMAP3_IVA2_BOOTADDR_MASK,
- OMAP343X_CTRL_REGADDR(
- OMAP343X_CONTROL_IVA2_BOOTADDR));
+ dsp_addr &= OMAP3_IVA2_BOOTADDR_MASK;
+ (*pdata->set_dsp_bootaddr)(dsp_addr);
/*
* Set bootmode to self loop if dsp_debug flag is true
*/
- __raw_writel((dsp_debug) ? OMAP3_IVA2_BOOTMOD_IDLE : 0,
- OMAP343X_CTRL_REGADDR(
- OMAP343X_CONTROL_IVA2_BOOTMOD));
+ bootmode = dsp_debug ? OMAP_IVA2_DSP_BOOTMODE_IDLE : 0;
+ (*pdata->set_dsp_bootmode)(bootmode);
}
}
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: omar.ramirez@ti.com (Omar Ramirez Luna)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] staging: tidspbridge: use new SCM DSP boot control fns
Date: Tue, 26 Oct 2010 11:16:03 -0500 [thread overview]
Message-ID: <1288109763-9446-5-git-send-email-omar.ramirez@ti.com> (raw)
In-Reply-To: <1288109763-9446-1-git-send-email-omar.ramirez@ti.com>
From: Paul Walmsley <paul@pwsan.com>
Use the new functions from SCM layer instead of handling registers
directly with __raw_writel, as explained in:
http://marc.info/?l=linux-omap&m=128779652429922&w=2
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
drivers/staging/tidspbridge/core/tiomap3430.c | 13 ++++++-------
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c
index f22bc12..b91d911 100644
--- a/drivers/staging/tidspbridge/core/tiomap3430.c
+++ b/drivers/staging/tidspbridge/core/tiomap3430.c
@@ -23,7 +23,7 @@
#include <dspbridge/host_os.h>
#include <linux/mm.h>
#include <linux/mmzone.h>
-#include <plat/control.h>
+#include <plat/iva2_dsp.h>
/* ----------------------------------- DSP/BIOS Bridge */
#include <dspbridge/dbdefs.h>
@@ -293,6 +293,7 @@ static int bridge_brd_start(struct bridge_dev_context *dev_ctxt,
u32 clk_cmd;
struct io_mgr *hio_mgr;
u32 ul_load_monitor_timer;
+ u8 bootmode;
struct omap_dsp_platform_data *pdata =
omap_dspbridge_dev->dev.platform_data;
@@ -334,15 +335,13 @@ static int bridge_brd_start(struct bridge_dev_context *dev_ctxt,
OMAP3430_RST1_IVA2_MASK, OMAP3430_IVA2_MOD,
OMAP2_RM_RSTCTRL);
/* Mask address with 1K for compatibility */
- __raw_writel(dsp_addr & OMAP3_IVA2_BOOTADDR_MASK,
- OMAP343X_CTRL_REGADDR(
- OMAP343X_CONTROL_IVA2_BOOTADDR));
+ dsp_addr &= OMAP3_IVA2_BOOTADDR_MASK;
+ (*pdata->set_dsp_bootaddr)(dsp_addr);
/*
* Set bootmode to self loop if dsp_debug flag is true
*/
- __raw_writel((dsp_debug) ? OMAP3_IVA2_BOOTMOD_IDLE : 0,
- OMAP343X_CTRL_REGADDR(
- OMAP343X_CONTROL_IVA2_BOOTMOD));
+ bootmode = dsp_debug ? OMAP_IVA2_DSP_BOOTMODE_IDLE : 0;
+ (*pdata->set_dsp_bootmode)(bootmode);
}
}
--
1.7.1
next prev parent reply other threads:[~2010-10-26 16:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 16:15 [PATCH v2 0/4] tidspbridge: SCM layer violation fixes Omar Ramirez Luna
2010-10-26 16:15 ` Omar Ramirez Luna
2010-10-26 16:16 ` [PATCH v2 1/4] OMAP: control: add functions for DSP boot address/mode control Omar Ramirez Luna
2010-10-26 16:16 ` Omar Ramirez Luna
2010-10-26 16:16 ` [PATCH v2 2/4] OMAP3: PM: update DSP reset code to use new SCM DSP boot control functions Omar Ramirez Luna
2010-10-26 16:16 ` Omar Ramirez Luna
2010-11-02 13:27 ` Kevin Hilman
2010-11-02 13:27 ` Kevin Hilman
2010-10-26 16:16 ` [PATCH v3 3/4] OMAP: dsp: convert OMAP3430 adaptation layer to use new SCM DSP boot control fns Omar Ramirez Luna
2010-10-26 16:16 ` Omar Ramirez Luna
2010-10-26 16:16 ` Omar Ramirez Luna [this message]
2010-10-26 16:16 ` [PATCH v2 4/4] staging: tidspbridge: " Omar Ramirez Luna
2010-10-26 17:13 ` [PATCH v2 0/4] tidspbridge: SCM layer violation fixes Felipe Contreras
2010-10-26 17:13 ` Felipe Contreras
2010-10-26 17:43 ` Omar Ramirez Luna
2010-10-26 17:43 ` Omar Ramirez Luna
2010-11-02 15:58 ` Omar Ramirez Luna
2010-11-02 15:58 ` Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288109763-9446-5-git-send-email-omar.ramirez@ti.com \
--to=omar.ramirez@ti.com \
--cc=ernesto@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=kalle.jokiniemi@digia.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
--cc=rene.sapiens@ti.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tero.kristo@nokia.com \
--cc=tony@atomide.com \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.