All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] tqm85xx: Update PCI code
Date: Wed, 27 Oct 2010 00:15:33 -0500	[thread overview]
Message-ID: <1288156533.1971.6.camel@ptyser-laptop> (raw)
In-Reply-To: <20101026195411.10C16152451@gemini.denx.de>

On Tue, 2010-10-26 at 21:54 +0200, Wolfgang Denk wrote:
> Dear Peter Tyser,
> 
> In message <1285785448-4703-3-git-send-email-ptyser@xes-inc.com> you wrote:
> > Update to use the recent, common FSL PCI initialization code.
> > 
> > Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> > CC: sr at denx.de
> > ---
> >  board/tqc/tqm85xx/law.c     |    4 +-
> >  board/tqc/tqm85xx/tlb.c     |   10 ++--
> >  board/tqc/tqm85xx/tqm85xx.c |  151 ++++++++++++-------------------------------
> >  include/configs/TQM85xx.h   |   20 +++---
> >  4 files changed, 59 insertions(+), 126 deletions(-)
> 
> This commit needs fixing.
> 
> First, it corrupts the output. Some patch like this should be added:
> 
> diff --git a/board/tqc/tqm85xx/tqm85xx.c b/board/tqc/tqm85xx/tqm85xx.c
> index 2c3885f..027c429 100644
> --- a/board/tqc/tqm85xx/tqm85xx.c
> +++ b/board/tqc/tqm85xx/tqm85xx.c
> @@ -567,7 +567,7 @@ void pci_init_board (void)
>  	if (!(devdisr & MPC85xx_DEVDISR_PCI1)) {
>  		SET_STD_PCI_INFO(pci_info[num], 1);
>  		pcie_ep = fsl_setup_hose(&pci1_hose, pci_info[num].regs);
> -		printf ("\n   PCI1:  %d bit, %s MHz, %s, %s, %s\n",
> +		printf ("PCI1:  %d bit, %s MHz, %s, %s, %s\n",
>  			(pci_32) ? 32 : 64,
>  			(pci_speed == 33333333) ? "33" :
>  			(pci_speed == 66666666) ? "66" : "unknown",
> @@ -591,7 +591,7 @@ void pci_init_board (void)
>  		}
>  #endif
>  	} else {
> -		printf("    PCI1: disabled\n");
> +		printf("PCI1:  disabled\n");
>  	}
>  #else
>  	setbits_be32(&gur->devdisr, MPC85xx_DEVDISR_PCI1);
> 
> 
> Even worse, we now see a (badly formatted, but this is just an added
> "bonus")
> 
> 	Scanning PCI bus 00
>     PCIE1 on bus 00 - 00
> 
> which is completely bogus as there on these boards nor on these
> processors.
> 
> 
> Can you please provide a fix?

Can you send the entire bootup output?  The code is based on Freescale
reference boards, eg the mpc8568mds, so I'd guess the problem is not
tqm85xx-specific.

Best,
Pete

  reply	other threads:[~2010-10-27  5:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29 18:37 [U-Boot] [PATCH 1/3] mpc8641hpcn: Update PCI code Peter Tyser
2010-09-29 18:37 ` [U-Boot] [PATCH 2/3] sbc8641d: " Peter Tyser
2010-10-20  6:37   ` Kumar Gala
2010-09-29 18:37 ` [U-Boot] [PATCH 3/3] tqm85xx: " Peter Tyser
2010-10-20  6:37   ` Kumar Gala
2010-10-26 19:54   ` Wolfgang Denk
2010-10-27  5:15     ` Peter Tyser [this message]
2010-10-27  6:47       ` Wolfgang Denk
2010-10-28 20:44         ` Peter Tyser
2010-10-28 21:20           ` Wolfgang Denk
2010-10-28 20:24   ` [U-Boot] [PATCH] fsl_pci_init: Make fsl_pci_init_port() PCI/PCIe aware Peter Tyser
2010-11-13 22:53     ` Wolfgang Denk
2010-11-14 15:01       ` Peter Tyser
2010-11-14 22:46     ` Wolfgang Denk
2010-10-20  6:37 ` [U-Boot] [PATCH 1/3] mpc8641hpcn: Update PCI code Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288156533.1971.6.camel@ptyser-laptop \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.